Fix global phase in inverse of UCGate #8508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The inverse of UCGate is defined by simply inverting the existing decomposition, but the inverse of the global phase was missing.
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
|
|
Cryoris
reviewed
Aug 10, 2022
|
Thanks for the fix! Could you also add a releasenote? 🙂 |
|
Thanks, @israelferrazaraujo. This PR also makes Isometry decomposition phase correct #4687. |
Co-authored-by: Julien Gacon <gaconju@gmail.com>
Hi @Cryoris, |
Cryoris
reviewed
Aug 11, 2022
releasenotes/notes/bugfix-ucgate-inverse-global_phase-c9655c13c22e5cf4.yaml
Outdated
Show resolved
Hide resolved
Cryoris
changed the title
Cryoris
added
stable backport potential
Pull Request Test Coverage Report for Build 2845394035
💛 - Coveralls |
adjs
reviewed
Aug 11, 2022
Cryoris
changed the title
Cryoris
approved these changes
Aug 14, 2022
mergify bot
pushed a commit
that referenced
this pull request
Aug 14, 2022
* Defines the inverse of the global phase The inverse of UCGate is defined by simply inverting the existing decomposition, but the inverse of the global phase was missing. * Tests the UCGate.inverse() function * Lint * Seed for building the matrices * Replace `unitary_simulator` by using `qiskit.quantum_info.Operator`. Co-authored-by: Julien Gacon <gaconju@gmail.com> * Import `Operator` class * Release notes * Lint * Test the phase of isometry decomposition * Removes the `prelude` from the release notes file * Replaces `matrix_equal` with `np.allclose` Co-authored-by: Julien Gacon <gaconju@gmail.com> (cherry picked from commit 82c85d8)
It's good to contribute to Qiskit. I hope to do more in the future. |
mergify bot
added a commit
that referenced
this pull request
Aug 17, 2022
* Defines the inverse of the global phase The inverse of UCGate is defined by simply inverting the existing decomposition, but the inverse of the global phase was missing. * Tests the UCGate.inverse() function * Lint * Seed for building the matrices * Replace `unitary_simulator` by using `qiskit.quantum_info.Operator`. Co-authored-by: Julien Gacon <gaconju@gmail.com> * Import `Operator` class * Release notes * Lint * Test the phase of isometry decomposition * Removes the `prelude` from the release notes file * Replaces `matrix_equal` with `np.allclose` Co-authored-by: Julien Gacon <gaconju@gmail.com> (cherry picked from commit 82c85d8) Co-authored-by: Israel F. Araujo <israelferrazaraujo@hotmail.com> Co-authored-by: Jake Lishman <jake.lishman@ibm.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
inverse()of theUCGateclass is defined by simply inverting the existing decomposition, but the inverse of the global phase was missing.Details and comments
The existing tests did not cover the
inverse()function of theUCGateclass, so I also included a new test.