-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add control flow support to UnitarySynthesis pass #8565
Conversation
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 3148714516
💛 - Coveralls |
From the meeting: we might want to replace this with the utility decorator on top of the |
I thought I'd added this further comment here already, sorry: I think this is one pass we'll want to do a little bit of a refactor before doing the recursion - it does a lot of non-trivial setup work before getting to the core, and we'll want to make sure we don't repeat that every time. It should still be easily doable with the helper in #8752, but it probably wants the inner core refactoring into "setup", "do", and "teardown" components, so we can only recurse the "do" part. |
The `UnitarySynthesis` runner does rather non-trivial setup of its internal plugin class before beginning the run. We don't want to re-initialise the plugin on each run, nor pay the time penalty for the setup. Instead, we refactor the actual "run" loop into its own function, and use that only for the recursion.
As discussed, I've updated this PR to only recurse the post-setup "run" loop component of the pass, and to use the new utility functions added in #8752. |
Summary
Add control flow support to UnitarySynthesis transpiler pass.
Details and comments