Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add final layout to output quantum circuit from transpiler #8597
Add final layout to output quantum circuit from transpiler #8597
Changes from 16 commits
2e69c42
37cab1b
9505948
fb7f119
64493ee
9cb2479
42f939c
a2e3385
f327fd9
53771c2
fd37a60
c5b84dc
156c77f
6b49f55
251098a
b842c86
f2833e4
a0c5521
d8c6488
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you plan to do this TODO in this PR? or another PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can save it for a follow up, unless you have an easy way to do it now. I don't have the bandwidth to investigate this further anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does it mean for
final_layout
to be optional? Is it that transpiler passes could swap qubits and not report it, or that they can leave this unset if they are not performing any swaps?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It primarily means the latter, if
final_layout
is None then there wasn't a permutation being caused by the routing stage in the compiler. Basically, the routing pass was skipped. There is also a backwards compatibility component to making this optional as well, but that's less likely to come up in practice outside of the routing pass not run.