Use np.array_split instead of np.split to support uneven splits in spsa._batch_evaluate #8634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sa._batch_evaluate
1ucian0
requested review from
a team,
manoelmarques and
woodsp-ibm
as code owners
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
1ucian0
added
Changelog: Bugfix
Pull Request Test Coverage Report for Build 2966979548
💛 - Coveralls |
|
@Cryoris can you take at look at this please. Since this is splitting multiple points to be evaluated there should never be an uneven split afaik since its a list of points each point being the same length. |
|
There can be uneven splits especially since SPSA does the calibration of the learning rate in the beginning, which uses 50 function evaluations. So if a user specifies e.g. |
Co-authored-by: Julien Gacon <gaconju@gmail.com>
Cryoris
reviewed
Aug 30, 2022
Co-authored-by: Julien Gacon <gaconju@gmail.com>
woodsp-ibm
reviewed
Aug 30, 2022
woodsp-ibm
reviewed
Aug 30, 2022
Cryoris
reviewed
Aug 31, 2022
Cryoris
reviewed
Aug 31, 2022
Cryoris
previously approved these changes
Aug 31, 2022
Cryoris
reviewed
Aug 31, 2022
Cryoris
approved these changes
Aug 31, 2022
Cryoris
added
stable backport potential
mergify bot
pushed a commit
that referenced
this pull request
Aug 31, 2022
…sa._batch_evaluate (#8634) * Use np.array_split instead of np.split to support uneven splits in spsa._batch_evaluate * better testing Co-authored-by: Julien Gacon <gaconju@gmail.com> * Update test/python/algorithms/optimizers/test_spsa.py Co-authored-by: Julien Gacon <gaconju@gmail.com> * len of a boolean * Apply suggestions from code review * Fix Sphinx ref Co-authored-by: Julien Gacon <gaconju@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 69ad6c6)
mergify bot
added a commit
that referenced
this pull request
Aug 31, 2022
…sa._batch_evaluate (#8634) (#8655) * Use np.array_split instead of np.split to support uneven splits in spsa._batch_evaluate * better testing Co-authored-by: Julien Gacon <gaconju@gmail.com> * Update test/python/algorithms/optimizers/test_spsa.py Co-authored-by: Julien Gacon <gaconju@gmail.com> * len of a boolean * Apply suggestions from code review * Fix Sphinx ref Co-authored-by: Julien Gacon <gaconju@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 69ad6c6) Co-authored-by: Luciano Bello <bel@zurich.ibm.com>
ElePT
pushed a commit
to ElePT/qiskit
that referenced
this pull request
Jun 27, 2023
…sa._batch_evaluate (Qiskit#8634) * Use np.array_split instead of np.split to support uneven splits in spsa._batch_evaluate * better testing Co-authored-by: Julien Gacon <gaconju@gmail.com> * Update test/python/algorithms/optimizers/test_spsa.py Co-authored-by: Julien Gacon <gaconju@gmail.com> * len of a boolean * Apply suggestions from code review * Fix Sphinx ref Co-authored-by: Julien Gacon <gaconju@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
ElePT
pushed a commit
to ElePT/qiskit-algorithms-test
that referenced
this pull request
Jul 17, 2023
…sa._batch_evaluate (Qiskit/qiskit#8634) * Use np.array_split instead of np.split to support uneven splits in spsa._batch_evaluate * better testing Co-authored-by: Julien Gacon <gaconju@gmail.com> * Update test/python/algorithms/optimizers/test_spsa.py Co-authored-by: Julien Gacon <gaconju@gmail.com> * len of a boolean * Apply suggestions from code review * Fix Sphinx ref Co-authored-by: Julien Gacon <gaconju@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes qiskit-community/qiskit-nature#797
Summary
The internal function
qiskit.algorithms.optimizers.spsa._batch_evaluateusesnp.splitinstead ofnp.array_split. This results in an exception as described here when the split is uneven.Details and comments
I used the static method
qiskit.algorithms.SPSA.estimate_stddevfor testing, since it was not directly tested and the method made it easier to parametrize in a way to cover the fix. However, I'm not sure if my input for that test is making any sense.