Support Sampler in Grover
#8647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiskit-bot
added
the
Community PR
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 3109198847
💛 - Coveralls |
t-imamichi
removed
the
Community PR
a-matsuo
requested review from
a team,
manoelmarques and
woodsp-ibm
as code owners
|
@a-matsuo I went ahead and added the deprecation msgs. They are all |
…into grover-primitives
…into grover-primitives
dlasecki
suggested changes
Sep 2, 2022
Cryoris
reviewed
Sep 2, 2022
Co-authored-by: Julien Gacon <gaconju@gmail.com>
…into grover-primitives
|
I cleaned up my codes. Does this QFI satisfy the requirements of VarQTE #8746 ? If so the design is fixed and I can finalize this PR. |
Maybe you meant to add that comment to the QFI PR? |
|
(Accidentally clicked the wrong button - duh!) |
woodsp-ibm
reviewed
Sep 21, 2022
woodsp-ibm
reviewed
Sep 22, 2022
woodsp-ibm
reviewed
Sep 22, 2022
woodsp-ibm
reviewed
Sep 22, 2022
woodsp-ibm
reviewed
Sep 22, 2022
woodsp-ibm
reviewed
Sep 22, 2022
woodsp-ibm
reviewed
Sep 22, 2022
woodsp-ibm
reviewed
Sep 22, 2022
ElePT
pushed a commit
to ElePT/qiskit
that referenced
this pull request
Jun 27, 2023
* wip added sampler * added sampler * fix lint * assert warns * fix reno * Add deprecation * fix unit tests for pending deprecation * remove unnecessary jupyter notebook * add pend.deprecation test * Update qiskit/algorithms/amplitude_amplifiers/grover.py Co-authored-by: Julien Gacon <gaconju@gmail.com> * added error handling * fix * use algorithm error * fix lint * fix * Update qiskit/algorithms/amplitude_amplifiers/grover.py Co-authored-by: Julien Gacon <gaconju@gmail.com> * Update qiskit/algorithms/amplitude_amplifiers/grover.py Co-authored-by: Julien Gacon <gaconju@gmail.com> * filter warnings * added unittests * lint * fix * fix * fix * fix * fix * lint * remove print * update sampler's options * changed the shots test to TODO * lint * added _prepare_grover in the unittest * fix test * changed the code-block in the release note * Update releasenotes/notes/add-grover-primitives-10f81efdba93703d.yaml * Update qiskit/algorithms/amplitude_amplifiers/grover.py * Update qiskit/algorithms/amplitude_amplifiers/grover.py * Apply suggestions from code review * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Manoel Marques <manoel.marques@ibm.com> Co-authored-by: Julien Gacon <gaconju@gmail.com> Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
ElePT
pushed a commit
to ElePT/qiskit-algorithms-test
that referenced
this pull request
Jul 17, 2023
* wip added sampler * added sampler * fix lint * assert warns * fix reno * Add deprecation * fix unit tests for pending deprecation * remove unnecessary jupyter notebook * add pend.deprecation test * Update qiskit/algorithms/amplitude_amplifiers/grover.py Co-authored-by: Julien Gacon <gaconju@gmail.com> * added error handling * fix * use algorithm error * fix lint * fix * Update qiskit/algorithms/amplitude_amplifiers/grover.py Co-authored-by: Julien Gacon <gaconju@gmail.com> * Update qiskit/algorithms/amplitude_amplifiers/grover.py Co-authored-by: Julien Gacon <gaconju@gmail.com> * filter warnings * added unittests * lint * fix * fix * fix * fix * fix * lint * remove print * update sampler's options * changed the shots test to TODO * lint * added _prepare_grover in the unittest * fix test * changed the code-block in the release note * Update releasenotes/notes/add-grover-primitives-10f81efdba93703d.yaml * Update qiskit/algorithms/amplitude_amplifiers/grover.py * Update qiskit/algorithms/amplitude_amplifiers/grover.py * Apply suggestions from code review * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Manoel Marques <manoel.marques@ibm.com> Co-authored-by: Julien Gacon <gaconju@gmail.com> Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Grover can now use
Samplerto calculate the results.Details and comments
close #8488