Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pending deprecate algo eigen_solvers #8651

Merged
merged 9 commits into from
Sep 29, 2022
Merged

Conversation

manoelmarques
Copy link
Member

Summary

Following #8640

Details and comments

@manoelmarques manoelmarques added Changelog: Deprecation Include in "Deprecated" section of changelog mod: algorithms Related to the Algorithms module labels Aug 31, 2022
@manoelmarques manoelmarques self-assigned this Aug 31, 2022
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@coveralls
Copy link

coveralls commented Aug 31, 2022

Pull Request Test Coverage Report for Build 3098094400

  • 18 of 18 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 84.4%

Totals Coverage Status
Change from base Build 3092681158: 0.004%
Covered Lines: 59290
Relevant Lines: 70249

💛 - Coveralls

@manoelmarques manoelmarques force-pushed the eigen_solvers branch 3 times, most recently from 90da758 to 3887e2e Compare August 31, 2022 21:50
@manoelmarques manoelmarques force-pushed the eigen_solvers branch 4 times, most recently from be9ae05 to d3f7e9a Compare September 2, 2022 22:05
@manoelmarques manoelmarques changed the title [WIP] Pending deprecate algo eigen_solvers Pending deprecate algo eigen_solvers Sep 6, 2022
@manoelmarques manoelmarques marked this pull request as ready for review September 6, 2022 02:11
@manoelmarques manoelmarques requested a review from a team as a code owner September 6, 2022 02:11
Copy link
Contributor

@Cryoris Cryoris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm not yet approving since the new algorithms haven't been merged yet 🙂

@woodsp-ibm woodsp-ibm added this to the 0.22 milestone Sep 12, 2022
Copy link
Member

@woodsp-ibm woodsp-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manoelmarques Thanks for taking care of this!

@mergify mergify bot merged commit 837d4ed into Qiskit:main Sep 29, 2022
@manoelmarques manoelmarques deleted the eigen_solvers branch October 27, 2022 20:15
ElePT pushed a commit to ElePT/qiskit that referenced this pull request Jun 27, 2023
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
ElePT pushed a commit to ElePT/qiskit-algorithms-test that referenced this pull request Jul 17, 2023
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Deprecation Include in "Deprecated" section of changelog mod: algorithms Related to the Algorithms module priority: high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants