Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CS, CSdg and CCZ gates to the CNOTDihedral class #8673

Merged
merged 8 commits into from
Sep 13, 2022

Conversation

ShellyGarion
Copy link
Member

Summary

close #8520
following PR #8583

Details and comments

Add CS, CSdg and CCZ gates to the CNOTDihedral class.

@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@coveralls
Copy link

coveralls commented Sep 4, 2022

Pull Request Test Coverage Report for Build 3041511246

  • 45 of 49 (91.84%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 84.322%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit/quantum_info/operators/dihedral/dihedral_circuits.py 45 49 91.84%
Totals Coverage Status
Change from base Build 3040943610: 0.02%
Covered Lines: 57880
Relevant Lines: 68642

💛 - Coveralls

Copy link
Contributor

@nkanazawa1989 nkanazawa1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ShellyGarion! This looks good to me. Since I'm not familiar with code here, I'll delegate the approval to who is more familiar with quantum info.

test/python/quantum_info/operators/test_dihedral.py Outdated Show resolved Hide resolved
itoko
itoko previously approved these changes Sep 8, 2022
Copy link
Contributor

@itoko itoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I just left a minor comment on improving readability but I don't think it prevent from merging this PR.

test/python/quantum_info/operators/test_dihedral.py Outdated Show resolved Hide resolved
@itoko itoko added the Changelog: New Feature Include in the "Added" section of the changelog label Sep 8, 2022
@ShellyGarion
Copy link
Member Author

Thank you @nkanazawa1989 and @itoko for your reviews!
I think that this PR is ready to go now. @ikkoham - could you please approve & merge it?

@ShellyGarion ShellyGarion added this to the 0.22 milestone Sep 11, 2022
Copy link
Contributor

@ikkoham ikkoham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adds new gates (CS and CCZ). It will make CNOTDihedral easier to use. The implementation looks good to me. Thanks.

@ikkoham ikkoham added mod: quantum info Related to the Quantum Info module (States & Operators) automerge labels Sep 13, 2022
@mergify mergify bot merged commit 7800999 into Qiskit:main Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: New Feature Include in the "Added" section of the changelog mod: quantum info Related to the Quantum Info module (States & Operators)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CCZ and CS gates to the circuit library and CNOTDihedral class
6 participants