-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ABC matrices for multi-controlled unitary #8718
Conversation
on branch controlled_abc changes to be submitted: modified: qiskit/circuit/add_control.py
on branch controlled_abc changes to be submitted: modified: qiskit/circuit/add_control.py
on branch controlled_abc changes to be submitted: modified: qiskit/circuit/add_control.py
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
ismael seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
ismael seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Co-Authored-By: @IsmaelCesar
Co-Authored-By: @cab4
Co-Authored-By: @Augusto12
Co-Authored-By: @adjs
Summary
Issue #5872
Changing the multi-controlled gate based on lemma 7.9 and corollary 7.4 from arXiv:quant-ph/9503016v1
Details and comments
Instead of three multi-controlled gates$R_z$ , $R_y$ and $R_z$ , using the unitary $U$ to be applied to the circuit by decomposing it into three gates $A$ , $B$ and $C$ where $ABC = I$ . And also using a multi-controlled phase gate to apply the local phase of the unitary: $e^{i\alpha}$