Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return DAGOpNode from dagcircuit.replace_block_with_op #8799

Merged
merged 4 commits into from
Oct 13, 2022

Conversation

enavarro51
Copy link
Contributor

Summary

Fixes #8724

Details and comments

This PR now returns the DAGOpNode that replaces the block from dagcircuit.replace_block_with_op.

@enavarro51 enavarro51 requested a review from a team as a code owner September 27, 2022 20:44
@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Sep 27, 2022
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@coveralls
Copy link

coveralls commented Sep 27, 2022

Pull Request Test Coverage Report for Build 3244884583

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 151 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.2%) to 84.547%

Files with Coverage Reduction New Missed Lines %
src/sabre_swap/sabre_dag.rs 1 94.44%
qiskit/extensions/quantum_initializer/squ.py 2 79.78%
src/sabre_swap/mod.rs 2 95.05%
src/results/marginalization.rs 40 65.52%
src/sampled_exp_val.rs 49 6.56%
src/optimize_1q_gates.rs 57 4.84%
Totals Coverage Status
Change from base Build 3242780185: -0.2%
Covered Lines: 61752
Relevant Lines: 73039

💛 - Coveralls

@mtreinish mtreinish added the Changelog: New Feature Include in the "Added" section of the changelog label Sep 28, 2022
@mtreinish mtreinish added this to the 0.23.0 milestone Sep 28, 2022
Copy link
Contributor

@kevinhartman kevinhartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. A nice improvement. Thanks!

@mtreinish mtreinish added the on hold Can not fix yet label Oct 12, 2022
@mtreinish
Copy link
Member

Just tagging as on hold to prevent an accidental merge as we're waiting on CI for 0.22.0 which should hopefully go out tomorrow. After 0.22.0 is ready we can remove that label and tag automerge.

@mtreinish mtreinish added automerge and removed on hold Can not fix yet labels Oct 13, 2022
@mergify mergify bot merged commit af459aa into Qiskit:main Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: New Feature Include in the "Added" section of the changelog Community PR PRs from contributors that are not 'members' of the Qiskit repo
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

small improvement to DAGCircuit.replace_block_with_op()
5 participants