Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce observable key for Estimator #8837

Merged
merged 2 commits into from
Oct 5, 2022

Conversation

ikkoham
Copy link
Contributor

@ikkoham ikkoham commented Oct 5, 2022

Summary

Fixes #8836

Details and comments

@ikkoham ikkoham requested review from a team and t-imamichi as code owners October 5, 2022 01:24
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@ikkoham ikkoham added bug Something isn't working Changelog: None Do not include in changelog mod: primitives Related to the Primitives module labels Oct 5, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3186947918

  • 16 of 16 (100.0%) changed or added relevant lines in 4 files are covered.
  • 125 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.2%) to 84.55%

Files with Coverage Reduction New Missed Lines %
src/stochastic_swap.rs 3 87.04%
src/dense_layout.rs 4 91.89%
src/sampled_exp_val.rs 14 63.93%
src/results/marginalization.rs 47 61.49%
src/optimize_1q_gates.rs 57 4.84%
Totals Coverage Status
Change from base Build 3184782875: -0.2%
Covered Lines: 61556
Relevant Lines: 72804

💛 - Coveralls

Copy link
Member

@mrossinek mrossinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ikkoham, for the quick fix of this!

I'm approving this here to point out that this also appears to fix the issues I was observing with qEOM over in qiskit-community/qiskit-nature#856 which triggered opening #8836

@Cryoris Cryoris added Changelog: Bugfix Include in the "Fixed" section of the changelog automerge and removed bug Something isn't working labels Oct 5, 2022
@mergify mergify bot merged commit 875b646 into Qiskit:main Oct 5, 2022
@ikkoham ikkoham deleted the primitives/observable-key branch October 5, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog Changelog: None Do not include in changelog mod: primitives Related to the Primitives module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Estimator fails when reused
6 participants