Add retworkx to generated module list in the .pylintrc #8867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the recent release of retworkx 0.12.0 the package has been renamed to rustworkx. For compatibility the retworkx python namespace continues to work and instead it just redirects imports to the new name. However, pylint is unable to reason about this dynamic import redirecting which causes it to fail in CI. While in 0.23.0 we'll update the requirement to the rustworkx name in order to unblock CI for the pending 0.22.0 release this commit adds the retworkx namespace to the list of generated modules which tells pylint to try not to detect members of the module.
mtreinish
added
type: qa
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 3219644802
💛 - Coveralls |
The earlier config update wasn't sufficient to get pylint to ignore all retworkx usage. This commit adds additional config entries for retworkx to try and get pylint to exclude it more thoroughly. Additionally, even with these global excludes on pylint there are a few places in the code where additional manual rule disabling was needed to get pylint to pass (further evidence for Qiskit#1179).
jakelishman
approved these changes
Oct 10, 2022
mergify bot
pushed a commit
that referenced
this pull request
Oct 10, 2022
* Add retworkx to generated module list in the .pylintrc With the recent release of retworkx 0.12.0 the package has been renamed to rustworkx. For compatibility the retworkx python namespace continues to work and instead it just redirects imports to the new name. However, pylint is unable to reason about this dynamic import redirecting which causes it to fail in CI. While in 0.23.0 we'll update the requirement to the rustworkx name in order to unblock CI for the pending 0.22.0 release this commit adds the retworkx namespace to the list of generated modules which tells pylint to try not to detect members of the module. * Expand config and add inline excludes where needed The earlier config update wasn't sufficient to get pylint to ignore all retworkx usage. This commit adds additional config entries for retworkx to try and get pylint to exclude it more thoroughly. Additionally, even with these global excludes on pylint there are a few places in the code where additional manual rule disabling was needed to get pylint to pass (further evidence for #1179). (cherry picked from commit 2f40849)
mergify bot
added a commit
that referenced
this pull request
Oct 10, 2022
* Add retworkx to generated module list in the .pylintrc With the recent release of retworkx 0.12.0 the package has been renamed to rustworkx. For compatibility the retworkx python namespace continues to work and instead it just redirects imports to the new name. However, pylint is unable to reason about this dynamic import redirecting which causes it to fail in CI. While in 0.23.0 we'll update the requirement to the rustworkx name in order to unblock CI for the pending 0.22.0 release this commit adds the retworkx namespace to the list of generated modules which tells pylint to try not to detect members of the module. * Expand config and add inline excludes where needed The earlier config update wasn't sufficient to get pylint to ignore all retworkx usage. This commit adds additional config entries for retworkx to try and get pylint to exclude it more thoroughly. Additionally, even with these global excludes on pylint there are a few places in the code where additional manual rule disabling was needed to get pylint to pass (further evidence for #1179). (cherry picked from commit 2f40849) Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With the recent release of retworkx 0.12.0 the package has been renamed to rustworkx. For compatibility the retworkx python namespace continues to work and instead it just redirects imports to the new name. However, pylint is unable to reason about this dynamic import redirecting which causes it to fail in CI. While in 0.23.0 we'll update the requirement to the rustworkx name in order to unblock CI for the pending 0.22.0 release this commit adds the retworkx namespace to the list of generated modules which tells pylint to try not to detect members of the module.
Details and comments