Fix pauli.evolve dtype casting error #8877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 3236028185
💛 - Coveralls |
mtreinish
added
Changelog: Bugfix
jakelishman
approved these changes
Oct 12, 2022
Comment on lines
-642
to
+644
| base_phase = np.mod(cls._phase_from_complex(op.coeff) + _count_y(base_x, base_z), 4) | ||
| base_phase = np.mod( | ||
| cls._phase_from_complex(op.coeff) + _count_y(base_x, base_z), 4, dtype=int | ||
| ) |
There was a problem hiding this comment.
I'm guessing this is int for consistency with other methods in this class?
mergify bot
pushed a commit
that referenced
this pull request
Oct 12, 2022
* Fix pauli phase evolve * Update for unsigned int phases Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit e6d23d5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #8438
Fixes issue where
Pauli.evolveandPauliList.evolvewould raise a dtype error when evolving by certain Clifford gates which modified the Pauli's phase.Details and comments
This fix make it so that rather than cast the dtype of the phase vector to a fixed type, it will accept any signed or unsigned integer dtype and work with that.