Fix VF2Layout and VF2PostLayout handling of instructions without error #8978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue in the VF2Layout and VF2PostLayout pass where the passes would potentially error in cases when a target was specified and there were instructions present without any error rates defined. In such cases the instructions should be treated as ideal (having no error) and the passes shouldn't fail. In cases where there are no error rates in the target for VF2Layout the first perfect match should be used, and for VF2PostLayout it should effectively be a no-op and not select a new layout. Fixes Qiskit#8970
mtreinish
added
stable backport potential
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 3323821440
💛 - Coveralls |
hay-k
reviewed
Oct 21, 2022
kevinhartman
previously approved these changes
Oct 21, 2022
mergify bot
pushed a commit
that referenced
this pull request
Oct 25, 2022
#8978) * Fix VF2Layout and VF2PostLayout handling of instructions without error This commit fixes an issue in the VF2Layout and VF2PostLayout pass where the passes would potentially error in cases when a target was specified and there were instructions present without any error rates defined. In such cases the instructions should be treated as ideal (having no error) and the passes shouldn't fail. In cases where there are no error rates in the target for VF2Layout the first perfect match should be used, and for VF2PostLayout it should effectively be a no-op and not select a new layout. Fixes #8970 * Add missing comma to comment * Exit early if score is 0 Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 6580d96)
mergify bot
added a commit
that referenced
this pull request
Oct 25, 2022
#8978) (#8997) * Fix VF2Layout and VF2PostLayout handling of instructions without error This commit fixes an issue in the VF2Layout and VF2PostLayout pass where the passes would potentially error in cases when a target was specified and there were instructions present without any error rates defined. In such cases the instructions should be treated as ideal (having no error) and the passes shouldn't fail. In cases where there are no error rates in the target for VF2Layout the first perfect match should be used, and for VF2PostLayout it should effectively be a no-op and not select a new layout. Fixes #8970 * Add missing comma to comment * Exit early if score is 0 Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 6580d96) Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit fixes an issue in the VF2Layout and VF2PostLayout pass where the passes would potentially error in cases when a target was specified and there were instructions present without any error rates defined. In such cases the instructions should be treated as ideal (having no error) and the passes shouldn't fail. In cases where there are no error rates in the target for VF2Layout the first perfect match should be used, and for VF2PostLayout it should effectively be a no-op and not select a new layout.
Details and comments
Fixes #8970