-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated networkx dag converter functions #9035
Conversation
This commit removes the deprecated DAGCircuit and DAGDependency networkx converter functions. These functions were deprecated in Qiskit#7927 as part of the 0.21.0 release. Since the minimum deprecation window has elapsed we can now remove these functions and the last usage of optional networkx usage in qiskit terra.
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 3385156307
💛 - Coveralls |
Sigh, the tutorials job fails because it was relying on the requirements-dev.txt entry to install networkx. I'll add networkx to the tutorials requirements list https://github.com/Qiskit/qiskit-terra/blob/main/.azure/tutorials-linux.yml#L27 in the meantime. |
5f283a9
to
92e50e8
Compare
Since Qiskitgh-9035 this documentation has been out-of-date. This updates it to give the correct information.
Since gh-9035 this documentation has been out-of-date. This updates it to give the correct information. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Since Qiskitgh-9035 this documentation has been out-of-date. This updates it to give the correct information. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Summary
This commit removes the deprecated DAGCircuit and DAGDependency networkx converter functions. These functions were deprecated in #7927 as part of the 0.21.0 release. Since the minimum deprecation window has elapsed we can now remove these functions and the last usage of optional networkx usage in qiskit terra.
Details and comments