🐛 fix deprecated Loader.load_module()
#9078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiskit-bot
added
the
Community PR
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
jakelishman
previously approved these changes
Nov 5, 2022
jakelishman
added
stable backport potential
Pull Request Test Coverage Report for Build 3437210643
💛 - Coveralls |
|
Just saw that CI wasn't really happy. Added a corresponding docstring to please the linter. |
jakelishman
approved these changes
Nov 10, 2022
mergify bot
pushed a commit
that referenced
this pull request
Nov 10, 2022
* 🐛 fix deprecated `Loader.load_module()` * 📝add docstring to please linter Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit ee0b036)
jakelishman
added
Changelog: Bugfix
levbishop
pushed a commit
that referenced
this pull request
Nov 11, 2022
* 🐛 fix deprecated `Loader.load_module()` * 📝add docstring to please linter Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit ee0b036)
mergify bot
added a commit
that referenced
this pull request
Nov 11, 2022
* 🐛 fix deprecated `Loader.load_module()` * 📝add docstring to please linter Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit ee0b036) Co-authored-by: Lukas Burgholzer <lukas.burgholzer@jku.at>
Cryoris
pushed a commit
to Cryoris/qiskit-terra
that referenced
this pull request
Jan 12, 2023
* 🐛 fix deprecated `Loader.load_module()` * 📝add docstring to please linter Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR ports a fix from Qiskit/rustworkx#728 that fixes the following
ImportWarningunderPython>=3.10ImportWarning: QiskitLoader.exec_module() not found; falling back to load_module()Details and comments
Some further context can be found in the corresponding retworkx PR Qiskit/rustworkx#728.
The underlying code was introduced in #5089.
Fixes #8853.