Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various improvements to AdaptVQE #9215

Merged
merged 5 commits into from
Dec 8, 2022

Conversation

mrossinek
Copy link
Member

Summary

This PR adds a few minor improvements to the AdaptVQE implementation.
Mostly more logging to make it easier to follow the progress of the algorithm.

Details and comments

@mrossinek mrossinek added the mod: algorithms Related to the Algorithms module label Nov 30, 2022
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@coveralls
Copy link

coveralls commented Nov 30, 2022

Pull Request Test Coverage Report for Build 3649047896

  • 16 of 16 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 84.593%

Totals Coverage Status
Change from base Build 3649046642: 0.003%
Covered Lines: 63411
Relevant Lines: 74960

💛 - Coveralls

@woodsp-ibm
Copy link
Member

As this adds history to the result object an end user sees I think this should have a reno, and that also perhaps mentions the additional logging since that's also something an end user can enable/view. As far as the history - this is the eigenvalues at each iteration right - maybe the docstring could be clearer in that regard - does it include the final value too in the history?

@mrossinek mrossinek force-pushed the adapt-vqe-improvements branch from 229404d to f920017 Compare December 1, 2022 15:32
@woodsp-ibm
Copy link
Member

Could we include testing the eigenvalue_history, maybe in one (or more) of the existing tests, to ensure its there in the result as expected.

@mrossinek
Copy link
Member Author

Could we include testing the eigenvalue_history, maybe in one (or more) of the existing tests, to ensure its there in the result as expected.

Will do that next week 👍

I was actually also thinking just now, that we could also store the gradient history as this might be useful in post-processing, too

@mrossinek mrossinek force-pushed the adapt-vqe-improvements branch from f920017 to f7ca510 Compare December 6, 2022 16:55
@woodsp-ibm woodsp-ibm added the Changelog: New Feature Include in the "Added" section of the changelog label Dec 6, 2022
@Qiskit Qiskit deleted a comment from mergify bot Dec 8, 2022
@Cryoris
Copy link
Contributor

Cryoris commented Dec 8, 2022

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Dec 8, 2022

requeue

☑️ This pull request is already queued

@Cryoris Cryoris removed the automerge label Dec 8, 2022
@mergify mergify bot merged commit 022aff6 into Qiskit:main Dec 8, 2022
Cryoris added a commit to Cryoris/qiskit-terra that referenced this pull request Jan 12, 2023
* Various improvements to AdaptVQE

* A little more detail for the reno

* retrigger CI

Co-authored-by: Julien Gacon <gaconju@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@mrossinek mrossinek deleted the adapt-vqe-improvements branch April 6, 2023 09:15
ElePT pushed a commit to ElePT/qiskit that referenced this pull request Jun 27, 2023
* Various improvements to AdaptVQE

* A little more detail for the reno

* retrigger CI

Co-authored-by: Julien Gacon <gaconju@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
ElePT pushed a commit to ElePT/qiskit-algorithms-test that referenced this pull request Jul 17, 2023
* Various improvements to AdaptVQE

* A little more detail for the reno

* retrigger CI

Co-authored-by: Julien Gacon <gaconju@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: New Feature Include in the "Added" section of the changelog mod: algorithms Related to the Algorithms module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants