-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various improvements to AdaptVQE #9215
Conversation
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 3649047896
💛 - Coveralls |
As this adds |
229404d
to
f920017
Compare
Could we include testing the eigenvalue_history, maybe in one (or more) of the existing tests, to ensure its there in the result as expected. |
Will do that next week 👍 I was actually also thinking just now, that we could also store the |
f920017
to
f7ca510
Compare
releasenotes/notes/adapt-vqe-improvements-8617aaa94a6e6621.yaml
Outdated
Show resolved
Hide resolved
@Mergifyio requeue |
☑️ This pull request is already queued |
* Various improvements to AdaptVQE * A little more detail for the reno * retrigger CI Co-authored-by: Julien Gacon <gaconju@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* Various improvements to AdaptVQE * A little more detail for the reno * retrigger CI Co-authored-by: Julien Gacon <gaconju@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* Various improvements to AdaptVQE * A little more detail for the reno * retrigger CI Co-authored-by: Julien Gacon <gaconju@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Summary
This PR adds a few minor improvements to the
AdaptVQE
implementation.Mostly more logging to make it easier to follow the progress of the algorithm.
Details and comments