Fix the aggregation argument of SamplingVQE
#9221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The aggregation was not passed to the DiagonalEstimator and had no effect. Also fixed a bug in the CVaR aggregation function, which overshot the expected value and improved the docs. Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com>
Cryoris
added
stable backport potential
Cryoris
requested review from
a team,
manoelmarques and
woodsp-ibm
as code owners
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 3618073711
💛 - Coveralls |
t-imamichi
reviewed
Dec 1, 2022
|
Thank you for the fix! |
Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com>
woodsp-ibm
approved these changes
Dec 1, 2022
Closed
mergify bot
pushed a commit
that referenced
this pull request
Dec 5, 2022
* Fix the ``aggregation`` argument of ``SamplingVQE`` The aggregation was not passed to the DiagonalEstimator and had no effect. Also fixed a bug in the CVaR aggregation function, which overshot the expected value and improved the docs. Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com> * Update qiskit/algorithms/minimum_eigensolvers/diagonal_estimator.py Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com> Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 0fe47d2)
Cryoris
added a commit
to Cryoris/qiskit-terra
that referenced
this pull request
Jan 12, 2023
* Fix the ``aggregation`` argument of ``SamplingVQE`` The aggregation was not passed to the DiagonalEstimator and had no effect. Also fixed a bug in the CVaR aggregation function, which overshot the expected value and improved the docs. Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com> * Update qiskit/algorithms/minimum_eigensolvers/diagonal_estimator.py Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com> Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
mergify bot
added a commit
that referenced
this pull request
Jan 13, 2023
* Fix the ``aggregation`` argument of ``SamplingVQE`` The aggregation was not passed to the DiagonalEstimator and had no effect. Also fixed a bug in the CVaR aggregation function, which overshot the expected value and improved the docs. Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com> * Update qiskit/algorithms/minimum_eigensolvers/diagonal_estimator.py Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com> Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 0fe47d2) Co-authored-by: Julien Gacon <gaconju@gmail.com> Co-authored-by: Jake Lishman <jake.lishman@ibm.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
ElePT
pushed a commit
to ElePT/qiskit
that referenced
this pull request
Jun 27, 2023
* Fix the ``aggregation`` argument of ``SamplingVQE`` The aggregation was not passed to the DiagonalEstimator and had no effect. Also fixed a bug in the CVaR aggregation function, which overshot the expected value and improved the docs. Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com> * Update qiskit/algorithms/minimum_eigensolvers/diagonal_estimator.py Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com> Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
ElePT
pushed a commit
to ElePT/qiskit-algorithms-test
that referenced
this pull request
Jul 17, 2023
* Fix the ``aggregation`` argument of ``SamplingVQE`` The aggregation was not passed to the DiagonalEstimator and had no effect. Also fixed a bug in the CVaR aggregation function, which overshot the expected value and improved the docs. Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com> * Update qiskit/algorithms/minimum_eigensolvers/diagonal_estimator.py Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com> Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the
SamplingVQEthe aggregation was not passed to the_DiagonalEstimatorand therefore had no effect!Also fixed a bug in the CVaR aggregation function, which overshot the expected value and improved the docs to include an explanation how a custom aggregation should look like.
Thanks @t-imamichi for finding the bug!