Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate old path to QPY #9225

Merged
merged 5 commits into from
Dec 8, 2022
Merged

Conversation

jakelishman
Copy link
Member

Summary

This includes a try/except for the old name in the backwards compatibility tests because we still need that test file to succeed against old versions of Terra to generate the old files.

Details and comments

This includes a try/except for the old name in the backwards
compatibility tests because we still need that test file to succeed
against old versions of Terra to generate the old files.
@jakelishman jakelishman added Changelog: Deprecation Include in "Deprecated" section of changelog mod: qpy Related to QPY serialization labels Dec 1, 2022
@jakelishman jakelishman added this to the 0.23.0 milestone Dec 1, 2022
@jakelishman jakelishman requested a review from a team as a code owner December 1, 2022 18:37
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@coveralls
Copy link

coveralls commented Dec 2, 2022

Pull Request Test Coverage Report for Build 3646958953

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.008%) to 84.591%

Files with Coverage Reduction New Missed Lines %
src/results/marginalization.rs 1 88.51%
Totals Coverage Status
Change from base Build 3641089515: -0.008%
Covered Lines: 63108
Relevant Lines: 74604

💛 - Coveralls

Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left an inline comment on the release notes, but that's more a note for when we're doing the release notes prep.

Comment on lines +4 to +6
The import ``qiskit.circuit.qpy_serialization`` is deprecated, as QPY has been promoted to the
top level. You should import the same objects from :mod:`qiskit.qpy` instead. The old path
will be removed in a future of Qiskit Terra.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd probably reword this a bit because "top level" might not be clear to people. But we can bikeshed over that in the release prep PR.

@mergify mergify bot merged commit 840f44a into Qiskit:main Dec 8, 2022
@jakelishman jakelishman deleted the deprecate-old-qpy branch December 8, 2022 10:45
Cryoris pushed a commit to Cryoris/qiskit-terra that referenced this pull request Jan 12, 2023
* Deprecate old path to QPY

This includes a try/except for the old name in the backwards
compatibility tests because we still need that test file to succeed
against old versions of Terra to generate the old files.

* Fix lint

* Do not warn on dunder access

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Deprecation Include in "Deprecated" section of changelog mod: qpy Related to QPY serialization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants