-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate old path to QPY #9225
Conversation
This includes a try/except for the old name in the backwards compatibility tests because we still need that test file to succeed against old versions of Terra to generate the old files.
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 3646958953
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I left an inline comment on the release notes, but that's more a note for when we're doing the release notes prep.
The import ``qiskit.circuit.qpy_serialization`` is deprecated, as QPY has been promoted to the | ||
top level. You should import the same objects from :mod:`qiskit.qpy` instead. The old path | ||
will be removed in a future of Qiskit Terra. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd probably reword this a bit because "top level" might not be clear to people. But we can bikeshed over that in the release prep PR.
* Deprecate old path to QPY This includes a try/except for the old name in the backwards compatibility tests because we still need that test file to succeed against old versions of Terra to generate the old files. * Fix lint * Do not warn on dunder access Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Summary
This includes a try/except for the old name in the backwards compatibility tests because we still need that test file to succeed against old versions of Terra to generate the old files.
Details and comments