Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated measure and reset circuit operations #9278

Merged
merged 6 commits into from
Dec 13, 2022
Merged

Remove deprecated measure and reset circuit operations #9278

merged 6 commits into from
Dec 13, 2022

Conversation

pedrorrivero
Copy link
Member

Summary

Removes measure and reset functions.

Details and comments

These two functions were deprecated in 0.19.

@pedrorrivero pedrorrivero requested a review from a team as a code owner December 11, 2022 18:05
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@pedrorrivero pedrorrivero changed the title Remove deprecated circuit operations Remove deprecated measure and reset circuit operations Dec 11, 2022
@pedrorrivero pedrorrivero mentioned this pull request Dec 11, 2022
Open
@coveralls
Copy link

coveralls commented Dec 11, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3689879283

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 84.569%
Files with Coverage Reduction New Missed Lines %
src/vf2_layout.rs 3 94.74%
Totals Coverage Status
Change from base Build 3685416648: -0.03%
Covered Lines: 63674
Relevant Lines: 75292
💛 - Coveralls

Cryoris
Cryoris reviewed Dec 12, 2022
View reviewed changes
Copy link
Contributor

@Cryoris Cryoris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup! Could you add a removal releasenote?

@Cryoris Cryoris added Changelog: API Change Include in the "Changed" section of the changelog automerge labels Dec 13, 2022
@jakelishman jakelishman added Changelog: Removal Include in the Removed section of the changelog and removed Changelog: API Change Include in the "Changed" section of the changelog labels Dec 13, 2022
@mergify mergify bot merged commit c4c79ff into Qiskit:main Dec 13, 2022
@pedrorrivero pedrorrivero deleted the remove-deprecated branch December 24, 2022 02:50
Cryoris added a commit to Cryoris/qiskit-terra that referenced this pull request Jan 12, 2023
@pedrorrivero @Cryoris @mergify
Remove deprecated measure and reset circuit operations (Qiskit#9278)
5499570 
* Remove measure

* Remove reset

* Add reno

* Update reno

Co-authored-by: Julien Gacon <gaconju@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cryoris Cryoris Cryoris approved these changes

Assignees
No one assigned
Labels
Changelog: Removal Include in the Removed section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pedrorrivero @qiskit-bot @coveralls @Cryoris @jakelishman