Many mentions to QASM should be changed to OpenQASM 2 #9351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ucian0
requested review from
a team,
jyu00,
manoelmarques and
woodsp-ibm
as code owners
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
mtreinish
added
documentation
…rra into replace/qasm/openqasm2
Pull Request Test Coverage Report for Build 5879092683
💛 - Coveralls |
jlapeyre
reviewed
Jan 12, 2023
|
In some places, we have "OpenQASM2", while in others "OpenQASM 2.0". Maybe I'm missing the context for why these are different. But we should probably use one or the other consistently. The spec and documentation in the openqasm repo on github seem to use "OpenQASM X" or "OpenQASM X.Y", but not "OpenQASMX". |
jlapeyre
reviewed
Jan 12, 2023
jlapeyre
reviewed
Jan 12, 2023
jlapeyre
requested changes
Jan 12, 2023
|
I didnt change it in the context of Qobj is because I was thinking at QASM qobj as a concept, as it is it's |
…rra; branch 'main' of github.com:Qiskit/qiskit-terra into replace/qasm/openqasm2
…rra into replace/qasm/openqasm2
Pull Request Test Coverage Report for Build 6351781302
💛 - Coveralls |
jakelishman
changed the title
jakelishman
approved these changes
Sep 29, 2023
jakelishman
added
the
stable backport potential
|
I was just planning to hit merge, but I see John's left a "request changes" review blocking that. @jlapeyre: I think all your comments are addressed within what we need to actually update - could you check again and approve / dismiss the block as appropriate? |
jlapeyre
approved these changes
Sep 29, 2023
mergify bot
pushed a commit
that referenced
this pull request
Sep 29, 2023
* Many mentions to QASM should be changed to OpenQASM2 * adjust tests * another round * suggestion in https://github.com/Qiskit/qiskit-terra/pull/9351/files#r1068676297 * https://github.com/Qiskit/qiskit-terra/pull/9351/files#r1068704441 * Normalise spacing of OpenQASM [23] --------- Co-authored-by: Jake Lishman <jake.lishman@ibm.com> (cherry picked from commit c6c9267) # Conflicts: # qiskit/extensions/hamiltonian_gate.py
jakelishman
pushed a commit
that referenced
this pull request
Sep 29, 2023
* Many mentions to QASM should be changed to OpenQASM2 * adjust tests * another round * suggestion in https://github.com/Qiskit/qiskit-terra/pull/9351/files#r1068676297 * https://github.com/Qiskit/qiskit-terra/pull/9351/files#r1068704441 * Normalise spacing of OpenQASM [23] --------- (cherry picked from commit c6c9267) Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 29, 2023
* Many mentions to QASM should be changed to OpenQASM2 * adjust tests * another round * suggestion in https://github.com/Qiskit/qiskit-terra/pull/9351/files#r1068676297 * https://github.com/Qiskit/qiskit-terra/pull/9351/files#r1068704441 * Normalise spacing of OpenQASM [23] --------- (cherry picked from commit c6c9267) Co-authored-by: Jake Lishman <jake.lishman@ibm.com> Co-authored-by: Luciano Bello <bel@zurich.ibm.com>
ElePT
pushed a commit
to ElePT/qiskit-ibm-provider
that referenced
this pull request
Oct 4, 2023
…9351) * Many mentions to QASM should be changed to OpenQASM2 * adjust tests * another round * suggestion in https://github.com/Qiskit/qiskit-terra/pull/9351/files#r1068676297 * https://github.com/Qiskit/qiskit-terra/pull/9351/files#r1068704441 * Normalise spacing of OpenQASM [23] --------- Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
rupeshknn
pushed a commit
to rupeshknn/qiskit
that referenced
this pull request
Oct 9, 2023
* Many mentions to QASM should be changed to OpenQASM2 * adjust tests * another round * suggestion in https://github.com/Qiskit/qiskit-terra/pull/9351/files#r1068676297 * https://github.com/Qiskit/qiskit-terra/pull/9351/files#r1068704441 * Normalise spacing of OpenQASM [23] --------- Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
ElePT
pushed a commit
to ElePT/qiskit-ibm-runtime
that referenced
this pull request
Oct 10, 2023
…9351) * Many mentions to QASM should be changed to OpenQASM2 * adjust tests * another round * suggestion in https://github.com/Qiskit/qiskit-terra/pull/9351/files#r1068676297 * https://github.com/Qiskit/qiskit-terra/pull/9351/files#r1068704441 * Normalise spacing of OpenQASM [23] --------- Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
ElePT
pushed a commit
to ElePT/qiskit-ibm-runtime
that referenced
this pull request
Dec 8, 2023
…9351) * Many mentions to QASM should be changed to OpenQASM2 * adjust tests * another round * suggestion in https://github.com/Qiskit/qiskit-terra/pull/9351/files#r1068676297 * https://github.com/Qiskit/qiskit-terra/pull/9351/files#r1068704441 * Normalise spacing of OpenQASM [23] --------- Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many parts of the documentation refer to "QASM" when they specifically talk about OpenQASM2. With many versions of QASM around and with OpenQASM 3.0 coming, I think it would help to be more explicit.