Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix escaping of identifiers in OQ3 output (backport #9660) #9673

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Fix escaping of identifiers in OQ3 output (backport #9660) #9673

merged 1 commit into from
Feb 27, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 27, 2023

This is an automatic backport of pull request #9660 done by Mergify.

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@jakelishman @mergify
Fix escaping of identifiers in OQ3 output (#9660)
8b5ddbc 
Since gh-9100 relaxed the naming restrictions on registers, it is now
necessary to manually escape register names during the export process.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit c29886d)
@mergify mergify bot requested a review from a team as a code owner February 27, 2023 13:47
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@jakelishman jakelishman added Changelog: Bugfix Include in the "Fixed" section of the changelog automerge mod: qasm2 Relating to OpenQASM 2 import or export labels Feb 27, 2023
@jakelishman jakelishman added this to the 0.23.3 milestone Feb 27, 2023
@mergify mergify bot merged commit d63dc4e into stable/0.23 Feb 27, 2023
@mergify mergify bot deleted the mergify/bp/stable/0.23/pr-9660 branch February 27, 2023 14:33
@jakelishman jakelishman added mod: qasm3 Related to OpenQASM 3 import or export and removed mod: qasm2 Relating to OpenQASM 2 import or export labels Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakelishman jakelishman jakelishman approved these changes

Assignees
No one assigned
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog mod: qasm3 Related to OpenQASM 3 import or export
Projects
None yet
Milestone
0.23.3
Development

Successfully merging this pull request may close these issues.
2 participants
@qiskit-bot @jakelishman