Remove unnecessary pip install in CI
#9756
Conversation
Eric-Arellano
added
type: qa
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
There was a problem hiding this comment.
I think if we're properly considering the safety, we actually want all the pip install lines collapsing onto a single line. We ought to force pip's resolver to consider all the constraints simultaneously, since it can get itself into an inconsistent state including changing prior fixed versions if it's called multiple times.
Pull Request Test Coverage Report for Build 4367280039
💛 - Coveralls |
Summary
For the lint job, we already are installing Terra via an editable install:
https://github.com/Qiskit/qiskit-terra/blob/fa7ac688fdce3ecc27fb7e13d8b2c3f8553b3ff8/.azure/lint-linux.yml#L25-L27
No need to reinstall Terra again. The Aer installation respects the prior editable install:
Details and comments
#8501 removed several calls to
python setup.py build_ext --inplacebecause they already were covered by the editable install on a prior line. But for the lint job, it replaced that line withpip install -e .-- I suspect it was only a mistake not realizing we already had the editable install a few lines above.