Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messages in Target-based GateDirection pass (backport #9787) #9791

Merged
merged 2 commits into from
Mar 14, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 14, 2023

This is an automatic backport of pull request #9787 done by Mergify.
Cherry-pick of 648da26 has failed:

On branch mergify/bp/stable/0.23/pr-9787
Your branch is up to date with 'origin/stable/0.23'.

You are currently cherry-picking commit 648da26c6.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   test/python/transpiler/test_gate_direction.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   qiskit/transpiler/passes/utils/gate_direction.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@mergify mergify bot requested a review from a team as a code owner March 14, 2023 13:27
@mergify mergify bot added the conflicts used by mergify when there are conflicts in a port label Mar 14, 2023
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

* Improve error messages in `Target`-based `GateDirection` pass

The `Target` version of `GateDirection` has more information available
to make better error messages. It can distinguish cases where the
failure is because a gate would be valid if flipped but the pass doesn't
know how to do it, and the case where the gate wouldn't be valid in
either direction.

* Reword error message on failed flip

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 648da26)
@jakelishman jakelishman force-pushed the mergify/bp/stable/0.23/pr-9787 branch from e3dc2bc to 376e040 Compare March 14, 2023 14:51
@jakelishman jakelishman added Changelog: Bugfix Include in the "Fixed" section of the changelog automerge and removed conflicts used by mergify when there are conflicts in a port labels Mar 14, 2023
@jakelishman jakelishman added this to the 0.23.3 milestone Mar 14, 2023
@mergify mergify bot merged commit 1d76f32 into stable/0.23 Mar 14, 2023
@mergify mergify bot deleted the mergify/bp/stable/0.23/pr-9787 branch March 14, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the "Fixed" section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants