Add support for disjoint coupling maps to SabreLayout #9802

mtreinish · 2023-03-15T23:22:07Z

Summary

This commit adds support to the SabreLayout pass for targeting disjoint
CouplingMap objects. The SABRE algorithm is written assuming a connected
graph, so to enable targeting a disjoint coupling graph this commit
decomposes the circuit into it's weakly connected components and then
maps those to the connected components of the coupling map and runs
the rust portion of the sabre code on each connected component of the
coupling graph. The results for each subgraph of the target backend is
then combined the pass is building the output dag.

In general the biggest potential issue for output quality right now is
the mapping function does not take into account the relative connectivity
of the dag component and the coupling map component. The mapping is just
done in order and it tries every component until it finds one that has
enough qubits. In the future we should use a heuristic to try and pack
the components based on what we expect will require the least amount of
swaps, but we can attempt that in a future PR.

Details and comments

This is still a very rough draft of this feature. Right now it does not handle barriers correctly at all
because an input circuit can have a multi-qubit barrier could correctly span more qubits than in a single
connected component and this will incorrectly treat that as a single dag component resulting in the circuit
being incorrectly mapped (or not being mappable at all). This prevents this from being used in the preset
pass managers at all because we need to insert a multiqubit barrier before the final measurement to prevent
routing past a measurement. This should be fixed by: b485d6a

I pushed this up primarily as a way to save my work between systems and share the basic approach while I'm
still developing the feature to fix these edge cases. But in isolation for circuits without barriers (or circuits where
the barrier width is less than or equal to the width of the coupling graph's connected components) this seems to
work correctly.

TODO:

Rebase after Add support to CouplingMap for disjoint qubits #9710 merges
Fix handling of barriers
Fix DAG splitting to ignore classical component
Expand testing
Add release note

This PR is based on top of #9710 in its current form, to see the contents of what will be this PR you can look at this diff: mtreinish/qiskit-core@disjoint-coupling-map...mtreinish:qiskit-core:layout_and_route_disjoint_coupling_maps

qiskit-bot · 2023-03-15T23:22:10Z

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@Qiskit/terra-core

qiskit/transpiler/passes/layout/disjoint_utils.py

qiskit/transpiler/passes/layout/sabre_layout.py

coveralls · 2023-03-16T16:52:19Z

Pull Request Test Coverage Report for Build 4692536440

132 of 145 (91.03%) changed or added relevant lines in 3 files are covered.
4 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.03%) to 85.802%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
qiskit/transpiler/passes/layout/sabre_layout.py	38	42	90.48%
qiskit/transpiler/passes/layout/disjoint_utils.py	88	97	90.72%

Files with Coverage Reduction	New Missed Lines	%
crates/qasm2/src/expr.rs	1	93.76%
crates/qasm2/src/lex.rs	3	91.65%

Totals
Change from base Build 4692324070:	0.03%
Covered Lines:	70422
Relevant Lines:	82075

💛 - Coveralls

mtreinish · 2023-03-21T18:56:36Z

qiskit/transpiler/passes/layout/disjoint_utils.py

+ other_node = uuid_map[node.op.label]
+ num_qubits = len(other_node.qargs) + len(node.qargs)
+ new_op = Barrier(num_qubits, label=barrier_uuid)
+ new_node = dag.replace_block_with_op([node, other_node], new_op, qubit_indices)


I am potentially worried about this potentially introducing a cycle when combining a barrier across qubits. I think it's possible this could cause that which is why I left the cycle check enabled for this. But we should try to confirm this before merging.

mtreinish · 2023-03-21T19:55:15Z

I added some full path transpile() tests in 5631d96

This gives a good example to show this in practice. Look at the 3 component circuit test, the input circuit is:

when running transpile() targeting the fake backend with this coupling map:

the output circuit looks like:

mtreinish · 2023-03-21T20:30:11Z

For the tests I just added I have to tag them as slow because they're taking exceedingly long in CI because of #9834: https://dev.azure.com/qiskit-ci/qiskit-terra/_build/results?buildId=44742&view=logs&j=e4ea27c2-3a16-5b32-7be8-0bf30fe9e828&t=793d4f07-8490-552a-798f-6a5657042d16&l=14039

mtreinish · 2023-03-23T21:31:06Z

qiskit/transpiler/passes/layout/disjoint_utils.py

+ connected_components = rx.weakly_connected_components(im_graph)
+ component_qubits = []
+ for component in connected_components:
+ component_qubits.append(set(qubit_map[x] for x in component))


A potential future optimization that I'm thinking of doing after this and #9840 merge is to skip the intermediate dag creation here, and go from connected qubits straight to a list of SabreDAGs. This should reduce the number of dag iterations we do and speed things up. But for the first iteration of this I'd like to keep everything unified on using full dags.

Now that Qiskit#9802 supports shared classical bits correctly this commit re-enables the tests disabled in the previous commit.

This commit adds support to the SabreLayout pass for targeting disjoint CouplingMap objects. The SABRE algorithm is written assuming a connected graph, so to enable targeting a disjoint coupling graph this commit decomposes the circuit into it's weakly connected components and then maps those to the connected components of the coupling map and runs the rust portion of the sabre code on each connected component of the coupling graph. The results for each subgraph of the target backend is then combined the pass is building the output dag. In general the biggest potential issue for output quality right now is the mapping function does not take into account the relative connectivity of the dag component and the coupling map component. The mapping is just done in order and it tries every component until it finds one that has enough qubits. In the future we should use a heuristic to try and pack the components based on what we expect will require the least amount of swaps, but we can attempt that in a future PR.

This commit fixes the handling of the barrier directive as the input DAG is split across multiple components. It is entirely valid for an input dag to have a multi-qubit barrier that spans multiple connected components. However, such barriers shouldn't be treated as multi-qubit operation for computing the connected components (as this result in the components being treated larger than they otherwise would be). To handle this edge case the logic introduced into this commit is prior to computing the connected components in the input dag we split each multi-qubit barrier into n single qubit barriers and assign a UUID label to each of the single qubit barriers. Then after we create each subgraph DAGCircuit object for each connected component we find all the barriers with a UUID and recombine them into a multi qubit barrier. This will retain the barriers characteristics for each connected component (as if it were in the original disjoint dag). Then in `SabreLayout` after we've built the output mapped dagcircuit we run the combination function one more time to combine the multiqubit dags across the different components, and in that process the UUID labels are removed. It is worth pointing out the downside with this approach is that it precludes preserving barriers with labels through transpile().

This commit fixes the handling of the separate_dag() function when the input DAGCircuit has shared classical bits between quantum connected components. In previous commits on this branch these would incorrectly be treated as a single connected component because from the perspective of rustworkx's weakly_connected_components() function there is no difference between the type of wires when computing the connected components of the graph. This commit fixes this by instead of computing the connected components of the DAG itself we create an interaction graph of just the quantum component and use that to find the connected components of qubits. From that we build subgraphs of the DAGCircuit for each connected component DAGCircuit. This ends up being less efficient, but produces the correct result by ignoring the classical component for computing the connected components.

kevinhartman

Looking good so far!

releasenotes/notes/support-disjoint-cmap-sabre-551ae4295131a449.yaml

test/python/compiler/test_transpiler.py

qiskit/transpiler/passes/layout/sabre_layout.py

qiskit/transpiler/passes/layout/disjoint_utils.py

Co-authored-by: Kevin Hartman <kevin@hart.mn>

…oint_coupling_maps

kevinhartman

Added a few more small comments. I'm fine with the PR as is (e.g. if time is of the essence).

qiskit/transpiler/passes/layout/disjoint_utils.py

…oint_coupling_maps

…ponents

kevinhartman

LGTM!

Now that Qiskit#9802 supports shared classical bits correctly this commit re-enables the tests disabled in the previous commit.

* Add support for disjoint coupling maps to SabreLayout This commit adds support to the SabreLayout pass for targeting disjoint CouplingMap objects. The SABRE algorithm is written assuming a connected graph, so to enable targeting a disjoint coupling graph this commit decomposes the circuit into it's weakly connected components and then maps those to the connected components of the coupling map and runs the rust portion of the sabre code on each connected component of the coupling graph. The results for each subgraph of the target backend is then combined the pass is building the output dag. In general the biggest potential issue for output quality right now is the mapping function does not take into account the relative connectivity of the dag component and the coupling map component. The mapping is just done in order and it tries every component until it finds one that has enough qubits. In the future we should use a heuristic to try and pack the components based on what we expect will require the least amount of swaps, but we can attempt that in a future PR. * Fix handling of barriers across separating components This commit fixes the handling of the barrier directive as the input DAG is split across multiple components. It is entirely valid for an input dag to have a multi-qubit barrier that spans multiple connected components. However, such barriers shouldn't be treated as multi-qubit operation for computing the connected components (as this result in the components being treated larger than they otherwise would be). To handle this edge case the logic introduced into this commit is prior to computing the connected components in the input dag we split each multi-qubit barrier into n single qubit barriers and assign a UUID label to each of the single qubit barriers. Then after we create each subgraph DAGCircuit object for each connected component we find all the barriers with a UUID and recombine them into a multi qubit barrier. This will retain the barriers characteristics for each connected component (as if it were in the original disjoint dag). Then in `SabreLayout` after we've built the output mapped dagcircuit we run the combination function one more time to combine the multiqubit dags across the different components, and in that process the UUID labels are removed. It is worth pointing out the downside with this approach is that it precludes preserving barriers with labels through transpile(). * Fix compatibility with Python < 3.9 * Adjust sorting order for mapping components * Add full path transpile() tests * Tag six component test as a slow test * Fix handling of splitting dags with shared classical bits This commit fixes the handling of the separate_dag() function when the input DAGCircuit has shared classical bits between quantum connected components. In previous commits on this branch these would incorrectly be treated as a single connected component because from the perspective of rustworkx's weakly_connected_components() function there is no difference between the type of wires when computing the connected components of the graph. This commit fixes this by instead of computing the connected components of the DAG itself we create an interaction graph of just the quantum component and use that to find the connected components of qubits. From that we build subgraphs of the DAGCircuit for each connected component DAGCircuit. This ends up being less efficient, but produces the correct result by ignoring the classical component for computing the connected components. * Add more test coverage and release notes * Don't route in SabreLayout with > 1 layout component with shared clbits When we run SabreLayout normally we're running both the layout and routing stage together. This is done for performance because the rust component is running routing internally so we avoid multiple back and forths between Python and Rust this way and it can lead to noticeable runtime improvements when doing this. However, in the case of > 1 circuit component that have any shared clbits we can not safetly route from the split dag components because the data dependency is lost for the classical component of the circuit is lost between the split components. To do routing without potentially reordering the data dependencies for the classical bits we need to run it on the combined dag all at once. For SabreLayout the easiest way to do that is to just have it work as a normal layout pass and let `SabreSwap` do the routing as it will have the full context and won't cause things to reorder incorrectly. This commit makes the change by checking if we have more than one component and any shared clbits between any components. If we do then we skip routing in SabreLayout and only return layout information. * Apply suggestions from code review Co-authored-by: Kevin Hartman <kevin@hart.mn> * Fix return type hint for map_components() * Cleanup variables and set usage in separate_dag * Remove duplicate lines in SabreLayout * Update error message text for routing_pass arg and disjoint cmap Co-authored-by: Kevin Hartman <kevin@hart.mn> * Improve docstring for map_components * Add comment explaining dag composition in run_pass_over_connected_components --------- Co-authored-by: Kevin Hartman <kevin@hart.mn>

* Add full path transpile() support for disjoint backends This commit finalizes the last piece of the full path transpile() support at all optimization levels. The primary piece to accomplish this was adding DenseLayout support for targeting a disjoint CouplingMap. With this piece added then all the default transpiler paths in the preset pass managers are able to support running with a disjoint CouplingMap. The biggest exception is the TrivialLayout pass which can result in an invalid layout being selected (where 2q connectivity crosses connected components). To handle this edge case a check is added to each routing stage to ensure the selected layout is valid for the coupling map and it is routable. This enables all the default paths at all 4 optimization levels for transpile() to be usable with disjoint connectivity. For optimization_level=0/TrivialLayout if the trivial layout is invalid the routing pass will raise an error saying as much. It's worth pointing out that NoiseAdaptiveLayout still doesn't support disjoint connectivity. However, since it's performance is poor and it's not used by default in any preset passmanager we can add this at a later date, but all other combinations of layout and routing methods should work (given the caveats with TrivialLayout) above. * Fix test determinism * Add future facing test for shared classical bits between components * Enable shared control flow test Now that #9802 supports shared classical bits correctly this commit re-enables the tests disabled in the previous commit. * Remove unused condition for faulty qubits backnedv1 path * Remove opt level 1 variant of test_chained_data_dependency * Use enumerate() in check_layout_isolated_to_component() Co-authored-by: Kevin Hartman <kevin@hart.mn> * Expand level 0 test coverage * Update test/python/compiler/test_transpiler.py Co-authored-by: Kevin Hartman <kevin@hart.mn> * s/check_layout_isolated_to_component/require_layout_isolated_to_component/g --------- Co-authored-by: Kevin Hartman <kevin@hart.mn>

* Add full path transpile() support for disjoint backends This commit finalizes the last piece of the full path transpile() support at all optimization levels. The primary piece to accomplish this was adding DenseLayout support for targeting a disjoint CouplingMap. With this piece added then all the default transpiler paths in the preset pass managers are able to support running with a disjoint CouplingMap. The biggest exception is the TrivialLayout pass which can result in an invalid layout being selected (where 2q connectivity crosses connected components). To handle this edge case a check is added to each routing stage to ensure the selected layout is valid for the coupling map and it is routable. This enables all the default paths at all 4 optimization levels for transpile() to be usable with disjoint connectivity. For optimization_level=0/TrivialLayout if the trivial layout is invalid the routing pass will raise an error saying as much. It's worth pointing out that NoiseAdaptiveLayout still doesn't support disjoint connectivity. However, since it's performance is poor and it's not used by default in any preset passmanager we can add this at a later date, but all other combinations of layout and routing methods should work (given the caveats with TrivialLayout) above. * Fix test determinism * Add future facing test for shared classical bits between components * Enable shared control flow test Now that Qiskit#9802 supports shared classical bits correctly this commit re-enables the tests disabled in the previous commit. * Remove unused condition for faulty qubits backnedv1 path * Remove opt level 1 variant of test_chained_data_dependency * Use enumerate() in check_layout_isolated_to_component() Co-authored-by: Kevin Hartman <kevin@hart.mn> * Expand level 0 test coverage * Update test/python/compiler/test_transpiler.py Co-authored-by: Kevin Hartman <kevin@hart.mn> * s/check_layout_isolated_to_component/require_layout_isolated_to_component/g --------- Co-authored-by: Kevin Hartman <kevin@hart.mn>

This commit fixes an issue in the `SabreLayout` pass when run on backends with a disjoint connectivity graph. The `SabreLayout` pass internally runs routing as part of its operation and as a performance efficiency we use that routing output by default. However, in the case of a disjoint coupling map we are splitting the circuit up into different subcircuits to map that to the connected components on the backend. Doing final routing as part of that split context is no sound because depsite the quantum operations being isolated to each component, other operations could have a dependency between the components. This was previously discovered during the development of Qiskit#9802 to be the case with classical data/bits, but since merging that it also has come up with barriers. To prevent any issues in the future this commit changes the SabreLayout pass to never use the routing output during the layout search when there is >1 connected component because we *need* to rerun routing on the full circuit after applying the layout. Fixes Qiskit#9995

* Don't run routing in SabreLayout with split components This commit fixes an issue in the `SabreLayout` pass when run on backends with a disjoint connectivity graph. The `SabreLayout` pass internally runs routing as part of its operation and as a performance efficiency we use that routing output by default. However, in the case of a disjoint coupling map we are splitting the circuit up into different subcircuits to map that to the connected components on the backend. Doing final routing as part of that split context is no sound because depsite the quantum operations being isolated to each component, other operations could have a dependency between the components. This was previously discovered during the development of #9802 to be the case with classical data/bits, but since merging that it also has come up with barriers. To prevent any issues in the future this commit changes the SabreLayout pass to never use the routing output during the layout search when there is >1 connected component because we *need* to rerun routing on the full circuit after applying the layout. Fixes #9995 * Remove unused shared_clbits logic * Remove swap and routing assertions from disjoint sabre layout tests * Fix lint

* Add support for disjoint coupling maps to SabreLayout This commit adds support to the SabreLayout pass for targeting disjoint CouplingMap objects. The SABRE algorithm is written assuming a connected graph, so to enable targeting a disjoint coupling graph this commit decomposes the circuit into it's weakly connected components and then maps those to the connected components of the coupling map and runs the rust portion of the sabre code on each connected component of the coupling graph. The results for each subgraph of the target backend is then combined the pass is building the output dag. In general the biggest potential issue for output quality right now is the mapping function does not take into account the relative connectivity of the dag component and the coupling map component. The mapping is just done in order and it tries every component until it finds one that has enough qubits. In the future we should use a heuristic to try and pack the components based on what we expect will require the least amount of swaps, but we can attempt that in a future PR. * Fix handling of barriers across separating components This commit fixes the handling of the barrier directive as the input DAG is split across multiple components. It is entirely valid for an input dag to have a multi-qubit barrier that spans multiple connected components. However, such barriers shouldn't be treated as multi-qubit operation for computing the connected components (as this result in the components being treated larger than they otherwise would be). To handle this edge case the logic introduced into this commit is prior to computing the connected components in the input dag we split each multi-qubit barrier into n single qubit barriers and assign a UUID label to each of the single qubit barriers. Then after we create each subgraph DAGCircuit object for each connected component we find all the barriers with a UUID and recombine them into a multi qubit barrier. This will retain the barriers characteristics for each connected component (as if it were in the original disjoint dag). Then in `SabreLayout` after we've built the output mapped dagcircuit we run the combination function one more time to combine the multiqubit dags across the different components, and in that process the UUID labels are removed. It is worth pointing out the downside with this approach is that it precludes preserving barriers with labels through transpile(). * Fix compatibility with Python < 3.9 * Adjust sorting order for mapping components * Add full path transpile() tests * Tag six component test as a slow test * Fix handling of splitting dags with shared classical bits This commit fixes the handling of the separate_dag() function when the input DAGCircuit has shared classical bits between quantum connected components. In previous commits on this branch these would incorrectly be treated as a single connected component because from the perspective of rustworkx's weakly_connected_components() function there is no difference between the type of wires when computing the connected components of the graph. This commit fixes this by instead of computing the connected components of the DAG itself we create an interaction graph of just the quantum component and use that to find the connected components of qubits. From that we build subgraphs of the DAGCircuit for each connected component DAGCircuit. This ends up being less efficient, but produces the correct result by ignoring the classical component for computing the connected components. * Add more test coverage and release notes * Don't route in SabreLayout with > 1 layout component with shared clbits When we run SabreLayout normally we're running both the layout and routing stage together. This is done for performance because the rust component is running routing internally so we avoid multiple back and forths between Python and Rust this way and it can lead to noticeable runtime improvements when doing this. However, in the case of > 1 circuit component that have any shared clbits we can not safetly route from the split dag components because the data dependency is lost for the classical component of the circuit is lost between the split components. To do routing without potentially reordering the data dependencies for the classical bits we need to run it on the combined dag all at once. For SabreLayout the easiest way to do that is to just have it work as a normal layout pass and let `SabreSwap` do the routing as it will have the full context and won't cause things to reorder incorrectly. This commit makes the change by checking if we have more than one component and any shared clbits between any components. If we do then we skip routing in SabreLayout and only return layout information. * Apply suggestions from code review Co-authored-by: Kevin Hartman <kevin@hart.mn> * Fix return type hint for map_components() * Cleanup variables and set usage in separate_dag * Remove duplicate lines in SabreLayout * Update error message text for routing_pass arg and disjoint cmap Co-authored-by: Kevin Hartman <kevin@hart.mn> * Improve docstring for map_components * Add comment explaining dag composition in run_pass_over_connected_components --------- Co-authored-by: Kevin Hartman <kevin@hart.mn>

* Add full path transpile() support for disjoint backends This commit finalizes the last piece of the full path transpile() support at all optimization levels. The primary piece to accomplish this was adding DenseLayout support for targeting a disjoint CouplingMap. With this piece added then all the default transpiler paths in the preset pass managers are able to support running with a disjoint CouplingMap. The biggest exception is the TrivialLayout pass which can result in an invalid layout being selected (where 2q connectivity crosses connected components). To handle this edge case a check is added to each routing stage to ensure the selected layout is valid for the coupling map and it is routable. This enables all the default paths at all 4 optimization levels for transpile() to be usable with disjoint connectivity. For optimization_level=0/TrivialLayout if the trivial layout is invalid the routing pass will raise an error saying as much. It's worth pointing out that NoiseAdaptiveLayout still doesn't support disjoint connectivity. However, since it's performance is poor and it's not used by default in any preset passmanager we can add this at a later date, but all other combinations of layout and routing methods should work (given the caveats with TrivialLayout) above. * Fix test determinism * Add future facing test for shared classical bits between components * Enable shared control flow test Now that Qiskit#9802 supports shared classical bits correctly this commit re-enables the tests disabled in the previous commit. * Remove unused condition for faulty qubits backnedv1 path * Remove opt level 1 variant of test_chained_data_dependency * Use enumerate() in check_layout_isolated_to_component() Co-authored-by: Kevin Hartman <kevin@hart.mn> * Expand level 0 test coverage * Update test/python/compiler/test_transpiler.py Co-authored-by: Kevin Hartman <kevin@hart.mn> * s/check_layout_isolated_to_component/require_layout_isolated_to_component/g --------- Co-authored-by: Kevin Hartman <kevin@hart.mn>

* Don't run routing in SabreLayout with split components This commit fixes an issue in the `SabreLayout` pass when run on backends with a disjoint connectivity graph. The `SabreLayout` pass internally runs routing as part of its operation and as a performance efficiency we use that routing output by default. However, in the case of a disjoint coupling map we are splitting the circuit up into different subcircuits to map that to the connected components on the backend. Doing final routing as part of that split context is no sound because depsite the quantum operations being isolated to each component, other operations could have a dependency between the components. This was previously discovered during the development of Qiskit#9802 to be the case with classical data/bits, but since merging that it also has come up with barriers. To prevent any issues in the future this commit changes the SabreLayout pass to never use the routing output during the layout search when there is >1 connected component because we *need* to rerun routing on the full circuit after applying the layout. Fixes Qiskit#9995 * Remove unused shared_clbits logic * Remove swap and routing assertions from disjoint sabre layout tests * Fix lint

mtreinish added on hold Can not fix yet Changelog: New Feature Include in the "Added" section of the changelog labels Mar 15, 2023

mtreinish added this to the 0.24.0 milestone Mar 15, 2023

alexanderivrii reviewed Mar 16, 2023

View reviewed changes

qiskit/transpiler/passes/layout/disjoint_utils.py Outdated Show resolved Hide resolved

mtreinish commented Mar 16, 2023

View reviewed changes

qiskit/transpiler/passes/layout/sabre_layout.py Outdated Show resolved Hide resolved

mtreinish mentioned this pull request Mar 16, 2023

Add support to CouplingMap for disjoint qubits #9710

Merged

mtreinish force-pushed the layout_and_route_disjoint_coupling_maps branch from c03da87 to f0a498e Compare March 21, 2023 17:30

mtreinish commented Mar 21, 2023

View reviewed changes

mtreinish mentioned this pull request Mar 21, 2023

Improve efficiency of VF2 family of layout pass scoring with disjoint circuits #9834

Closed

mtreinish force-pushed the layout_and_route_disjoint_coupling_maps branch from 5631d96 to ed32409 Compare March 22, 2023 19:03

mtreinish mentioned this pull request Mar 22, 2023

Add full path transpile() support for disjoint backends #9840

Merged

mtreinish changed the title ~~[WIP] Add support for disjoint coupling maps to SabreLayout~~ Add support for disjoint coupling maps to SabreLayout Mar 23, 2023

mtreinish commented Mar 23, 2023

View reviewed changes

mtreinish added a commit to mtreinish/qiskit-core that referenced this pull request Mar 23, 2023

Enable shared control flow test

c3fdaca

Now that Qiskit#9802 supports shared classical bits correctly this commit re-enables the tests disabled in the previous commit.

mtreinish added 8 commits March 24, 2023 18:30

Fix compatibility with Python < 3.9

4611e08

Adjust sorting order for mapping components

2801978

Add full path transpile() tests

e637d19

Tag six component test as a slow test

35fdc84

Add more test coverage and release notes

1ddcb03

mtreinish force-pushed the layout_and_route_disjoint_coupling_maps branch from 1af8166 to 1ddcb03 Compare March 24, 2023 22:48

mtreinish removed the on hold Can not fix yet label Mar 24, 2023

mtreinish marked this pull request as ready for review March 24, 2023 22:48

mtreinish requested a review from a team as a code owner March 24, 2023 22:48

kevinhartman reviewed Apr 13, 2023

View reviewed changes

mtreinish and others added 6 commits April 13, 2023 11:32

Apply suggestions from code review

0019460

Co-authored-by: Kevin Hartman <kevin@hart.mn>

Fix return type hint for map_components()

01690e5

Cleanup variables and set usage in separate_dag

7085288

Remove duplicate lines in SabreLayout

fe54898

Update error message text for routing_pass arg and disjoint cmap

1fc880e

Co-authored-by: Kevin Hartman <kevin@hart.mn>

Merge remote-tracking branch 'origin/main' into layout_and_route_disj…

a093283

…oint_coupling_maps

mtreinish requested a review from kevinhartman April 13, 2023 16:42

kevinhartman previously approved these changes Apr 13, 2023

View reviewed changes

qiskit/transpiler/passes/layout/disjoint_utils.py Outdated Show resolved Hide resolved

qiskit/transpiler/passes/layout/disjoint_utils.py Show resolved Hide resolved

mtreinish added 3 commits April 13, 2023 14:08

Merge remote-tracking branch 'origin/main' into layout_and_route_disj…

117223c

…oint_coupling_maps

Improve docstring for map_components

08afa5d

Add comment explaining dag composition in run_pass_over_connected_com…

5df53a7

…ponents

mtreinish dismissed kevinhartman’s stale review via 5df53a7 April 13, 2023 18:19

mtreinish requested a review from kevinhartman April 13, 2023 18:39

kevinhartman approved these changes Apr 13, 2023

View reviewed changes

kevinhartman added this pull request to the merge queue Apr 13, 2023

Merged via the queue into Qiskit:main with commit 2534efb Apr 13, 2023

mtreinish added a commit to mtreinish/qiskit-core that referenced this pull request Apr 13, 2023

Enable shared control flow test

a178ce5

Now that Qiskit#9802 supports shared classical bits correctly this commit re-enables the tests disabled in the previous commit.

mtreinish mentioned this pull request Apr 20, 2023

Don't run routing in SabreLayout with split components #10000

Merged

mtreinish mentioned this pull request Aug 28, 2023

Fix virtual/physical-qubit distinction in Sabre #10712

Merged

mtreinish deleted the layout_and_route_disjoint_coupling_maps branch August 28, 2023 12:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for disjoint coupling maps to SabreLayout #9802

Add support for disjoint coupling maps to SabreLayout #9802

mtreinish commented Mar 15, 2023 •

edited

Loading

qiskit-bot commented Mar 15, 2023

coveralls commented Mar 16, 2023 •

edited

Loading

mtreinish Mar 21, 2023

mtreinish commented Mar 21, 2023

mtreinish commented Mar 21, 2023

mtreinish Mar 23, 2023

kevinhartman left a comment

kevinhartman left a comment

kevinhartman left a comment

Add support for disjoint coupling maps to SabreLayout #9802

Add support for disjoint coupling maps to SabreLayout #9802

Conversation

mtreinish commented Mar 15, 2023 • edited Loading

Summary

Details and comments

qiskit-bot commented Mar 15, 2023

coveralls commented Mar 16, 2023 • edited Loading

Pull Request Test Coverage Report for Build 4692536440

💛 - Coveralls

mtreinish Mar 21, 2023

Choose a reason for hiding this comment

mtreinish commented Mar 21, 2023

mtreinish commented Mar 21, 2023

mtreinish Mar 23, 2023

Choose a reason for hiding this comment

kevinhartman left a comment

Choose a reason for hiding this comment

kevinhartman left a comment

Choose a reason for hiding this comment

kevinhartman left a comment

Choose a reason for hiding this comment

mtreinish commented Mar 15, 2023 •

edited

Loading

coveralls commented Mar 16, 2023 •

edited

Loading