Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin lxml in constraints #1154

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Pin lxml in constraints #1154

merged 1 commit into from
Apr 1, 2024

Conversation

mtreinish
Copy link
Member

The recent lxml 5.2.0 release is raising an exception about a packaging change that moved a submodule into a different location during the docs build. We don't actually directly use lxml in rustworkx (or the docs), but it gets pulled in via a dependency of jupyter-sphinx (it's deeper in the dependency tree than jupyter-sphinx's immediate dependencies). To workaround this until things are updated to take this into account this commit pins the lxml version in the constraints.txt file so we don't pull in the latest release.

The recent lxml 5.2.0 release is raising an exception about a packaging
change that moved a submodule into a different location during the docs
build. We don't actually directly use lxml in rustworkx (or the docs),
but it gets pulled in via a dependency of jupyter-sphinx (it's deeper
in the dependency tree than jupyter-sphinx's immediate dependencies). To
workaround this until things are updated to take this into account this
commit pins the lxml version in the constraints.txt file so we don't
pull in the latest release.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8512519057

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 96.503%

Files with Coverage Reduction New Missed Lines %
src/shortest_path/all_pairs_bellman_ford.rs 6 95.53%
Totals Coverage Status
Change from base Build 8470915706: -0.03%
Covered Lines: 17136
Relevant Lines: 17757

💛 - Coveralls

@IvanIsCoding IvanIsCoding merged commit ca0df8e into Qiskit:main Apr 1, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants