Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Hashmap from the katz centrality computation #1174

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

Paulo-21
Copy link
Contributor

Proposed fix for issue #1173

@CLAassistant
Copy link

CLAassistant commented Apr 24, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant

This comment was marked as duplicate.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8823148065

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 96.518%

Files with Coverage Reduction New Missed Lines %
rustworkx-core/src/centrality.rs 1 98.61%
Totals Coverage Status
Change from base Build 8822969880: 0.02%
Covered Lines: 17325
Relevant Lines: 17950

💛 - Coveralls

Copy link
Collaborator

@IvanIsCoding IvanIsCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, that was a detail that we did not catch on the review.

In general the bottleneck will still be iterating over the edges of the graph, but this shouldn't hurt the performance

@IvanIsCoding IvanIsCoding merged commit cc01ee8 into Qiskit:main Apr 25, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants