Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lexicographical_topological_sort function to rustworkx-core #1197

Merged
merged 4 commits into from
May 22, 2024

Conversation

mtreinish
Copy link
Member

This commit adds a rust generic implementation of the lexicographical topological sort function that was previously only exposed via the python interface to rustworkx-core. This new function is used internally by rustworkx and replaces the python specific implementation that used to be there. But it now exposes an interface to use it to rust.

Fixes: #1165

This commit adds a rust generic implementation of the lexicographical
topological sort function that was previously only exposed via the
python interface to rustworkx-core. This new function is used internally
by rustworkx and replaces the python specific implementation that used
to be there. But it now exposes an interface to use it to rust.

Fixes: Qiskit#1165
Copy link
Collaborator

@IvanIsCoding IvanIsCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IvanIsCoding IvanIsCoding added the automerge Queue a approved PR for merging label May 21, 2024
@coveralls
Copy link

coveralls commented May 22, 2024

Pull Request Test Coverage Report for Build 9183805319

Details

  • 112 of 112 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 96.537%

Totals Coverage Status
Change from base Build 9183738698: 0.06%
Covered Lines: 16784
Relevant Lines: 17386

💛 - Coveralls

@mtreinish mtreinish merged commit 3e51301 into Qiskit:main May 22, 2024
28 of 30 checks passed
@mtreinish mtreinish deleted the lexicographical-topo-sort-core branch May 22, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Queue a approved PR for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move lexicographical_topological_sort() functionality to rustworkx-core
3 participants