Use stestr again for unittests #1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the release of Python 3.12.1 we stopped using stest in CI because 3.12.1 introduced a breaking API change to the unittest runner API that broke a dependency of stestr, testtools. This has been worked around with a new testtools release so we can restore using stestr in CI again which should improve test run throughput. This commit restores using stestr for the test CI jobs and local runs. The cibuildwheel config remains unchanged and uses the stdlib unittest runner still, just for simplicity so we don't need to install additional test dependencies.
mtreinish
force-pushed
the
use-stestr-again
branch
from
9469cff
to
45fd5aa
Compare
Pull Request Test Coverage Report for Build 9573740108Details
💛 - Coveralls |
IvanIsCoding
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the release of Python 3.12.1 we stopped using stest in CI because 3.12.1 introduced a breaking API change to the unittest runner API that broke a dependency of stestr, testtools. This has been worked around with a new testtools release so we can restore using stestr in CI again which should improve test run throughput. This commit restores using stestr for the test CI jobs and local runs. The cibuildwheel config remains unchanged and uses the stdlib unittest runner still, just for simplicity so we don't need to install additional test dependencies.