-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustworkx-core: fix docs build warnings #1333
Conversation
Pull Request Test Coverage Report for Build 12098431514Details
💛 - Coveralls |
This reverts commit 1977f66.
1aaa1f1
to
7025585
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the warnings!
Can't wait for rust-lang/rust#56232 though. Once I tried running rust-lang/rust#56232 (comment) and Clippy found so many issues with our doc examples, one of these days I should try to fix them
@@ -46,6 +46,8 @@ jobs: | |||
run: pushd rustworkx-core && cargo test && popd | |||
- name: rustworkx-core Docs | |||
run: pushd rustworkx-core && cargo doc && popd | |||
env: | |||
RUSTDOCFLAGS: '-D warnings' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is very weird that this isn't a command line option. But it is a Cargo limitation, there is not much we can do
Fix the warnings during the
rustworkx-core
documentation build. See e.g. this job:2a61e43 fails the
rustworkx-core
documentation build step to avoid regressions. The change could be reverted on similar ground to #1330 (review).