Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with rustworkx.visit annotations #1353

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix issues with rustworkx.visit annotations #1353

wants to merge 1 commit into from
+33 −22

Conversation

IvanIsCoding
Copy link
Collaborator

Closes #1352

@IvanIsCoding IvanIsCoding requested a review from mtreinish January 5, 2025 23:04
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12623682306

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.825%
Totals Coverage Status
Change from base Build 12548747025: 0.0%
Covered Lines: 18360
Relevant Lines: 19160
💛 - Coveralls

@barakatzir
Copy link

Why not combine the visit.pyi into visit.py?

@barakatzir barakatzir mentioned this pull request Jan 6, 2025
Open
@IvanIsCoding
Copy link
Collaborator Author

Why not combine the visit.pyi into visit.py?

visit.py gets ignored in my experience. There is another issue where someone reported the visit annotations as missing when it was only visit.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtreinish mtreinish Awaiting requested review from mtreinish

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typing: visit not re-exported and partial/missing annotations
3 participants
@IvanIsCoding @coveralls @barakatzir