-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added empty and complete graph generators #679
Conversation
Pull Request Test Coverage Report for Build 3230698228
💛 - Coveralls |
Does this PR also require a |
Yes I think a reno release note would be appropriate here, I would say add two notes as features, one documenting the addition of the empty graph functions and the second documenting adding the complete graph functions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this LGTM, thanks for the update. I have just one small suggestion inline on the release note for complete_graph
we should refer to it being the same as mesh_graph
to document it's just an alias. But other than that I think this is ready to merge
Added new generator functions, :func:`~rustworkx.generators.complete_graph`, | ||
and :func:`~rustworkx.generators.directed_complete_graph` to the | ||
``rustworkx.generators`` module that will generate a complete graph. | ||
For example: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add something here about this being identical to mesh_graph()
but using a more standard name for the functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the reno @mtreinish. Let me know if further changes are required
Added generators for
empty
andcomplete
graphs.Partially addresses #150.