Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed stray reno and added script to check the same #691

Merged
merged 5 commits into from
Oct 4, 2022
Merged

Fixed stray reno and added script to check the same #691

merged 5 commits into from
Oct 4, 2022

Conversation

prakharb10
Copy link
Contributor

Closes #678.

@coveralls
Copy link

coveralls commented Oct 4, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3184963155

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 97.081%
Totals Coverage Status
Change from base Build 3183946832: 0.007%
Covered Lines: 13569
Relevant Lines: 13977
💛 - Coveralls

IvanIsCoding
IvanIsCoding reviewed Oct 4, 2022
View reviewed changes
Copy link
Collaborator

@IvanIsCoding IvanIsCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling this, just left two minor comments

.github/workflows/main.yml Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
@IvanIsCoding IvanIsCoding added the automerge Queue a approved PR for merging label Oct 4, 2022
@mergify mergify bot merged commit 63de4cb into Qiskit:main Oct 4, 2022
@prakharb10 prakharb10 deleted the prakharb10/issue678 branch October 5, 2022 06:03
@prakharb10 prakharb10 mentioned this pull request Nov 15, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvanIsCoding IvanIsCoding IvanIsCoding approved these changes

Assignees
No one assigned
Labels
automerge Queue a approved PR for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Erroneous Reno in tests
3 participants
@prakharb10 @coveralls @IvanIsCoding