Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix QEMU-based Linux wheel jobs. #713

Merged
merged 1 commit into from
Oct 24, 2022
Merged

Conversation

kevinhartman
Copy link
Contributor

Summary

There appears to be an issue with memory consumption under the hood when using QEMU with Rust cargo:
rust-lang/cargo#10583.

This is causing the CI wheel workflow to run out of memory and fail for QEMU-based jobs, e.g.:
https://github.com/Qiskit/rustworkx/actions/runs/3245206601/jobs/5420102493#step:7:325

Details and comments

From the discussion on the linked issue, the workaround is to tell cargo to use the Git executable directly, rather than libgit2.

Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this

@mtreinish mtreinish added the automerge Queue a approved PR for merging label Oct 24, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3316335561

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 96.942%

Totals Coverage Status
Change from base Build 3314164240: -0.02%
Covered Lines: 13471
Relevant Lines: 13896

💛 - Coveralls

@mergify mergify bot merged commit 5af7835 into Qiskit:main Oct 24, 2022
@IvanIsCoding
Copy link
Collaborator

Genuinely, awesome work on digging through the issues to find a simple solution. I spent a whole day trying to build the library with cargo-zigbuild and couldn't fix it.

@mtreinish mtreinish added the stable-backport-potential This PR or issue is potentially worth backporting for inclusion in a stable branch label Nov 8, 2022
mergify bot pushed a commit that referenced this pull request Nov 8, 2022
mergify bot added a commit that referenced this pull request Nov 9, 2022
(cherry picked from commit 5af7835)

Co-authored-by: Kevin Hartman <kevin@hart.mn>
TeoZosa added a commit to TeoZosa/structlog-sentry-logger that referenced this pull request Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Queue a approved PR for merging stable-backport-potential This PR or issue is potentially worth backporting for inclusion in a stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants