Fix support of sequence protocol for returned lists #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the `sequence` option to PyO3's `pyclass`, so that the `sq_length` slot is implemented [1]. Implementing this method is required for sequence types, or Python C API functions like `PySequence_Size` will fail with an error. The `reversed` built-in method relies on `PySequence_*` methods. A test reversing `NodeIndices` is added to guard against future violations of the sequence protocol. Fixes Qiskit#696. [1]: PyO3/pyo3#2567
|
|
|
|
mtreinish
added
the
stable-backport-potential
Pull Request Test Coverage Report for Build 3423049318
💛 - Coveralls |
mtreinish
approved these changes
Nov 8, 2022
Sure, you're welcome! The |
mergify bot
pushed a commit
that referenced
this pull request
Nov 9, 2022
* Fix support of sequence protocol for returned lists Add the `sequence` option to PyO3's `pyclass`, so that the `sq_length` slot is implemented [1]. Implementing this method is required for sequence types, or Python C API functions like `PySequence_Size` will fail with an error. The `reversed` built-in method relies on `PySequence_*` methods. A test reversing `NodeIndices` is added to guard against future violations of the sequence protocol. Fixes #696. [1]: PyO3/pyo3#2567 * Add release note Co-authored-by: Matthew Treinish <mtreinish@kortar.org> (cherry picked from commit 4592bc0)
mergify bot
added a commit
that referenced
this pull request
Nov 9, 2022
…735) * Bump pyo3 from 0.17.2 to 0.17.3 (#723) Bumps [pyo3](https://github.com/pyo3/pyo3) from 0.17.2 to 0.17.3. - [Release notes](https://github.com/pyo3/pyo3/releases) - [Changelog](https://github.com/PyO3/pyo3/blob/main/CHANGELOG.md) - [Commits](PyO3/pyo3@v0.17.2...v0.17.3) --- updated-dependencies: - dependency-name: pyo3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit d91f488) # Conflicts: # Cargo.lock # Cargo.toml * Fix support of sequence protocol for returned lists (#730) * Fix support of sequence protocol for returned lists Add the `sequence` option to PyO3's `pyclass`, so that the `sq_length` slot is implemented [1]. Implementing this method is required for sequence types, or Python C API functions like `PySequence_Size` will fail with an error. The `reversed` built-in method relies on `PySequence_*` methods. A test reversing `NodeIndices` is added to guard against future violations of the sequence protocol. Fixes #696. [1]: PyO3/pyo3#2567 * Add release note Co-authored-by: Matthew Treinish <mtreinish@kortar.org> (cherry picked from commit 4592bc0) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tino Wagner <ich@tinowagner.com> Co-authored-by: Ivan Carvalho <ivancarv@student.ubc.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
sequenceoption to PyO3'spyclass, so that thesq_lengthslot is implemented 1. Implementing this method is required for sequence types, or Python C API functions likePySequence_Sizewill fail with an error.The
reversedbuilt-in method relies onPySequence_*methods. A test reversingNodeIndicesis added to guard against future violations of the sequence protocol.Fixes #696.