Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move grid_graph generator to rustworkx-core #773

Merged
merged 3 commits into from
Jan 6, 2023
Merged

Move grid_graph generator to rustworkx-core #773

merged 3 commits into from
Jan 6, 2023

Conversation

enavarro51
Copy link
Contributor

This PR migrates the grid_graph generator to rustwokx-core. It's based on #758.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3858917764

  • 88 of 96 (91.67%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 97.027%
Changes Missing Coverage Covered Lines Changed/Added Lines %
rustworkx-core/src/generators/grid_graph.rs 68 76 89.47%
Files with Coverage Reduction New Missed Lines %
src/shortest_path/all_pairs_dijkstra.rs 1 98.54%
Totals Coverage Status
Change from base Build 3852140468: 0.1%
Covered Lines: 13445
Relevant Lines: 13857
💛 - Coveralls

IvanIsCoding
IvanIsCoding approved these changes Jan 6, 2023
View reviewed changes
Copy link
Collaborator

@IvanIsCoding IvanIsCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IvanIsCoding IvanIsCoding added the automerge Queue a approved PR for merging label Jan 6, 2023
@mergify mergify bot merged commit 61c4802 into Qiskit:main Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvanIsCoding IvanIsCoding IvanIsCoding approved these changes

Assignees
No one assigned
Labels
automerge Queue a approved PR for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@enavarro51 @coveralls @IvanIsCoding