Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move lollipop_graph generator to rustworkx-core #777

Merged
merged 7 commits into from
Jan 14, 2023
Merged

Move lollipop_graph generator to rustworkx-core #777

merged 7 commits into from
Jan 14, 2023

Conversation

enavarro51
Copy link
Contributor

This PR migrates the lollipop_graph generator to rustwokx-core. It's based on #758.

@mtreinish mtreinish added this to the 0.13.0 milestone Jan 11, 2023
@IvanIsCoding IvanIsCoding added the automerge Queue a approved PR for merging label Jan 13, 2023
IvanIsCoding
IvanIsCoding approved these changes Jan 13, 2023
View reviewed changes
Copy link
Collaborator

@IvanIsCoding IvanIsCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, we are almost there. Thanks for helping us with this

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3915703836

  • 80 of 80 (100.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.04%) to 96.998%
Files with Coverage Reduction New Missed Lines %
src/shortest_path/all_pairs_dijkstra.rs 2 98.54%
Totals Coverage Status
Change from base Build 3915683972: 0.04%
Covered Lines: 13733
Relevant Lines: 14158
💛 - Coveralls

@mergify mergify bot merged commit 810391b into Qiskit:main Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvanIsCoding IvanIsCoding IvanIsCoding approved these changes

Assignees
No one assigned
Labels
automerge Queue a approved PR for merging
Projects
None yet
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.
4 participants
@enavarro51 @coveralls @IvanIsCoding @mtreinish