Add todo_nodes sort to maintain deterministic output in token_swapper #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5222916748
💛 - Coveralls |
mtreinish
approved these changes
Jun 9, 2023
mtreinish
added
automerge
mergify bot
pushed a commit
that referenced
this pull request
Jun 9, 2023
(cherry picked from commit af4af62)
1ucian0
added a commit
to 1ucian0/qiskit-terra
that referenced
this pull request
Feb 11, 2024
github-merge-queue bot
pushed a commit
to Qiskit/qiskit
that referenced
this pull request
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a sort to the
todo_nodesVec intoken_swapperin order to maintain deterministic output when using a seed. This problem appeared when implementing Qiskit/qiskit#10001 and some of the tests produced correct, but random output.