Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Qiskit Ecosystem theme #926

Merged
merged 3 commits into from
Jul 24, 2023
Merged

Conversation

Eric-Arellano
Copy link
Contributor

@Eric-Arellano Eric-Arellano commented Jul 10, 2023

The new theme is based on top of Furo from pip's docs. It is more functional and modern than the old Pytorch theme. It's also designed for ecosystem projects, e.g. no top Qiskit nav bar.

@coveralls
Copy link

coveralls commented Jul 10, 2023

Pull Request Test Coverage Report for Build 5650435174

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.423%

Totals Coverage Status
Change from base Build 5649967794: 0.0%
Covered Lines: 15283
Relevant Lines: 15850

💛 - Coveralls

@Eric-Arellano Eric-Arellano changed the title [wip] Upgrade to new Qiskit sphinx theme [wip] Switch to Qiskit Ecosystem theme Jul 18, 2023
@mtreinish mtreinish added the stable-backport-potential This PR or issue is potentially worth backporting for inclusion in a stable branch label Jul 24, 2023
@mtreinish mtreinish added this to the 0.13.1 milestone Jul 24, 2023
@Eric-Arellano Eric-Arellano changed the title [wip] Switch to Qiskit Ecosystem theme Switch to Qiskit Ecosystem theme Jul 24, 2023
@Eric-Arellano Eric-Arellano marked this pull request as ready for review July 24, 2023 21:06
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the docs look great with this new theme. Thanks for the hard work on improving the theme package and pushing the update here.

The only thing missing is a solution for #824 to really make the docs feel complete :)

@mtreinish mtreinish added the automerge Queue a approved PR for merging label Jul 24, 2023
@mergify mergify bot merged commit e9b9c12 into Qiskit:main Jul 24, 2023
26 checks passed
mergify bot pushed a commit that referenced this pull request Jul 24, 2023
* Upgrade to new Qiskit sphinx theme

* Use ecosystem theme

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit e9b9c12)
@Eric-Arellano Eric-Arellano deleted the new-theme branch July 24, 2023 23:17
mergify bot added a commit that referenced this pull request Jul 25, 2023
* Upgrade to new Qiskit sphinx theme

* Use ecosystem theme

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit e9b9c12)

Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
raynelfss pushed a commit to raynelfss/rustworkx that referenced this pull request Aug 10, 2023
* Upgrade to new Qiskit sphinx theme

* Use ecosystem theme

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Queue a approved PR for merging stable-backport-potential This PR or issue is potentially worth backporting for inclusion in a stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants