Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add .so files to gitignore #965

Merged
merged 1 commit into from
Aug 13, 2023
Merged

add .so files to gitignore #965

merged 1 commit into from
Aug 13, 2023

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented Aug 13, 2023

When following the instructions in https://github.com/Qiskit/rustworkx#develop-mode after compilation I got a .so file not ignored by gitignore.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5848380179

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.474%

Totals Coverage Status
Change from base Build 5836463872: 0.0%
Covered Lines: 15378
Relevant Lines: 15940

💛 - Coveralls

Copy link
Collaborator

@IvanIsCoding IvanIsCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IvanIsCoding IvanIsCoding merged commit 3f0fafc into Qiskit:main Aug 13, 2023
24 checks passed
@mtreinish
Copy link
Member

FWIW, we had a line for this in the .gitignore before https://github.com/Qiskit/rustworkx/blob/main/.gitignore#L14-L15 but it was missed in the rustworkx rename so it wasn't matching anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants