-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #17 チェックサムファイルの更新スクリプト #65
Merged
KEINOS
merged 11 commits into
Qithub-BOT:master
from
KEINOS:fix-issue17-generate-hash-and-sig
Jul 15, 2021
Merged
Issue #17 チェックサムファイルの更新スクリプト #65
KEINOS
merged 11 commits into
Qithub-BOT:master
from
KEINOS:fix-issue17-generate-hash-and-sig
Jul 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m/KEINOS/Fork_QiiCipher into fix-issue17-generate-hash-and-sig
- coreutils が抜けていました
お手すきでいいので、レビューお願いしまーす。 ping @yoshi389111 |
ちょっと気になったのは、スクリプトの一覧があちこちに入ってしまっていることです。 LIST_SCRIPT_BIN="archive check dec enc keygen sign verify checkkeylength dearchive" 今後コマンドを追加する予定はあまりないかと思いますが、もしあった場合修正もれなどがありそうに思います。 例えば、チェックサムファイルを bin ではなく別の場所に配置して、binの中のファイルはすべてコマンドだとした方が良いかもしれない、と思いました。 この PR としては、問題ないと思います。 |
ご確認ありがとうございます!
確かに。漏れますね、ぜったい。とりあえず Issue を別途たてて対応するとして、マージさせていただき 💪 💪 !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
やること
checksum.sha512
の値を更新するスクリプトchecksum.sha512.sig
)はリリースに含めることにします。リポジトリに入れてもセキュリティの意味はない& PR とは関係がないため。やらないこと
.sig
)の自動化