adding generate_a_HtmlFile_from_mdFile test #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your PR. |
Qiwen-Yu
reviewed
Nov 22, 2021
Qiwen-Yu
reviewed
Nov 22, 2021
test.py
Outdated
| lang = "fr" | ||
| g=Generator(inp,output,stylesheet,lang) | ||
| g.parse_markdown(inp) | ||
| assert expectedOutputFile.exists() |
There was a problem hiding this comment.
The above line might be changed something as """<title>Zen</title>
Somebody
2021-10-15
Zen
Section 1
Simple is better than complex.
Although practicality beats purity.
Section 2
Need more practice.
"""There was a problem hiding this comment.
It is so strange when I test it local and all tests pass
There was a problem hiding this comment.
I got it, I forgot to generate wrapper in the test
|
I will merge now, but I am wondering if we should remove the expectedOutputFile first such as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Qiwen-Yu, I added 1 test to check if an HTML file will be generated in the expected destination if the user passes in an MD file.
Thank you :)