-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for space-separated RGB #58
Conversation
No, I'm afraid not. I thought that was disallowed by the spec, but I see was wrong 😣 Sorry about that. I'm not using the library in my project anymore so I don't have an immediate need to work on that myself. You're very welcome to fork my branch to add support, of course. |
Done. Thanks very much! |
ccbea79
to
a6c9763
Compare
It was a duplicate of another test earlier in the file, and wasn't testing the "no alpha" case.
a6c9763
to
a2ea739
Compare
Thanks :) |
Published as |
You're very welcome @Qix- , thank you for making this! Now that I'm looking at it again, I think I should have used |
PR welcome. :) |
This is almost exactly the same as @htunnicliff's excellent PR #55, but just for the RGB case instead of HSL. It adds support for values like:
The motivation for this was that Chrome's developer tools now uses that form of notation for RGB colors, and I got bitten by blindly copying and pasting one into my CSS 😅