Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to ESM #264

Merged
merged 2 commits into from
Feb 11, 2025
Merged

move to ESM #264

merged 2 commits into from
Feb 11, 2025

Conversation

LitoMore
Copy link
Collaborator

@LitoMore LitoMore commented Feb 8, 2025

Closes #256
Closes #258

Changes

  • Require Node.js 18
  • Move to ESM
  • Add type definitions
    • Most of them are from the latest @types/color, but I made some tweaks
  • Update GitHub Actions settings
  • Bump color-convert@3
  • Bump color-string@2

@Qix- I didn't list all converter use cases in index.test-d.ts. Please let me know if you want to them all.

And some tests are missing, like .toJSON(). Should I fix them in this PR?

@LitoMore LitoMore marked this pull request as ready for review February 9, 2025 14:20
@LitoMore LitoMore requested a review from Qix- February 9, 2025 14:20
@Qix-
Copy link
Owner

Qix- commented Feb 9, 2025

I didn't list all converter use cases in index.test-d.ts. Please let me know if you want to them all.

I'd just test a few random, weird ones, but doing all of them isn't necessary IMO.

And some tests are missing, like .toJSON(). Should I fix them in this PR?

If you'd like. I think that functionality is pretty standard, iirc.

@LitoMore
Copy link
Collaborator Author

LitoMore commented Feb 9, 2025

@Qix- .toJSON() tests added now.

@Qix-
Copy link
Owner

Qix- commented Feb 11, 2025

Looks good, merge when ready :)

@LitoMore LitoMore merged commit f14937b into Qix-:master Feb 11, 2025
3 checks passed
@LitoMore LitoMore deleted the esm branch February 11, 2025 21:19
@Qix-
Copy link
Owner

Qix- commented Feb 12, 2025

Published as 5.0.0 :) thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@types/color outdated Provide esm version / exports
2 participants