Skip to content

Commit

Permalink
Add codecov.io to possible improvements
Browse files Browse the repository at this point in the history
  • Loading branch information
Qkessler committed Dec 1, 2023
1 parent ee90e50 commit fb9c57e
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
7 changes: 7 additions & 0 deletions .github/DOCS.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,10 @@ As we don't run on nightly, we don't really need to check whether nightly breaks
[source](https://crates.io/crates/loom)

Loom is great and it's backed by Tokio, but it would mean a bigger investment in making the threads we use be loom specific. Definitely something to iterate on, as we get onto Async Emacs.

### codecov.io
> Enhance Your Testing the Codecov Way: Codecov is the all-in-one code coverage reporting solution for any test suite — giving developers actionable insights to deploy reliable code with confidence.
[source](https://about.codecov.io), [repo of Github Action](https://github.com/codecov/codecov-action)

If we want to add a badge or have nice reports on coverage, we could investigate CodeCov. It requires a token that should be added to the secrets of the repository: `CODECOV_TOKEN`.
4 changes: 0 additions & 4 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,3 @@ jobs:
run: cargo generate-lockfile
- name: cargo llvm-cov
run: cargo llvm-cov --locked --all-features --lcov --output-path lcov.info
- name: Upload to codecov.io
uses: codecov/codecov-action@v3
with:
fail_ci_if_error: true

0 comments on commit fb9c57e

Please sign in to comment.