Add config.plist patching pipeline #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… entry generation
- Adds patching pipeline to the CLI for the build command and standalone patch command
Qonfused
added
type:feature
This comment was marked as duplicate.
This comment was marked as duplicate.
- Refactored config patching to insert `build_config` properties - Added Kext grouping by topological node for additional sorting - Bumped priority for path specifiers to be parsed first if a valid filepath points to a file
…ialdata` patching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the required pipeline code to handle patching the config.plist file with other plist patches or declarative yaml patches.
Additionally, this brings support for using the config.plist schema as a fallback for missing keys in a config.plist file. This is useful for users who want to use an existing config.plist file as part of an upgrade to a newer version of the OpenCore (where only the newer schema is required).
By nature of this solution for upgrading builds, this proposal resolves #1 as-is. However, additional infrastructure will be required to support downgrading builds or handle an unknown config.plist version.
The most trivial solution would be to map the OpenCore.efi hash to the appropriate version + commit ranges, which has the required code to read these hashes under the
get_opencore_checksummethod.