Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

feat: support qovery-container-names input #13

Merged
merged 2 commits into from
May 5, 2023
Merged

Conversation

Thiht
Copy link
Contributor

@Thiht Thiht commented Apr 17, 2023

Using names is more convenient than IDs for us

@Thiht
Copy link
Contributor Author

Thiht commented May 4, 2023

@erebe @benjaminch Hi! Could you get a look at this please? 😊

@benjaminch
Copy link
Collaborator

Hello @Thiht !
Sorry I've missed that, we will have a look.
Cheers

Copy link
Collaborator

@benjaminch benjaminch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a nitpick comment to handle if you want ;)
Let me know if you need any help.

Again thanks a lot for your contribution here, very appreciated ;)

github-action/main.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@benjaminch benjaminch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@benjaminch benjaminch merged commit 73a168c into Qovery:main May 5, 2023
@benjaminch
Copy link
Collaborator

@Thiht Here you go, thanks again for your contribution :)
https://github.com/Qovery/qovery-github-actions/releases/tag/v0.15.7

@Thiht
Copy link
Contributor Author

Thiht commented May 5, 2023

Happy to contribute! thanks for the release

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants