Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for edge case where you only have single x value in coordinate #656

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

johnzl-777
Copy link
Collaborator

Should fix #655 , a new release of BloqadeLattices will be necessary along with Bloqade to let users have access to this.

@johnzl-777 johnzl-777 linked an issue Jan 22, 2024 that may be closed by this pull request
@johnzl-777 johnzl-777 requested a review from weinbe58 January 22, 2024 16:47
Copy link
Member

@weinbe58 weinbe58 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weinbe58
Copy link
Member

Probably should add a test to cover this case.

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (69e4eb4) 77.02% compared to head (1a3d7af) 71.96%.

❗ Current head 1a3d7af differs from pull request most recent head c35aa92. Consider uploading reports for the commit c35aa92 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #656      +/-   ##
==========================================
- Coverage   77.02%   71.96%   -5.06%     
==========================================
  Files         106       82      -24     
  Lines        5279     4077    -1202     
==========================================
- Hits         4066     2934    -1132     
+ Misses       1213     1143      -70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnzl-777
Copy link
Collaborator Author

johnzl-777 commented Jan 22, 2024

Added two unit tests to cover text-based pretty printing
Covers:

  • Coordinates with single x values
  • Coordinates with both x and y provided

@johnzl-777 johnzl-777 merged commit 4649cc5 into master Jan 22, 2024
25 of 27 checks passed
@johnzl-777 johnzl-777 deleted the 655-bug-atomlist-pretty-printing-edge-case-failure branch January 22, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] AtomList Pretty Printing edge case failure
2 participants