-
Notifications
You must be signed in to change notification settings - Fork 11
[WIP] fix config feature add #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request! It is really a useful feature to have.
I added a few comments, there are also some general aspects that this PR can be improved. The first one is adding a test, like try fixing some configurations and enumerate the solution space, then see if it works as expected. This is a good place to have the test: https://github.com/QuEraComputing/GenericTensorNetworks.jl/blob/master/test/networks/MaxCut.jl .
It would be nice if you can add a similar feature to other graph problems, which is not hard, I can help with that.
The priority of the changes is
correctness > performance > the rest (e.g. naming)
One you have a test and the CI passes, I can approve this PR.
Thanks again for your effort!
Codecov Report
@@ Coverage Diff @@
## master #40 +/- ##
==========================================
+ Coverage 93.64% 93.73% +0.09%
==========================================
Files 24 24
Lines 1432 1453 +21
==========================================
+ Hits 1341 1362 +21
Misses 91 91
Continue to review full report at Codecov.
|
Cheers! |
Add the feature that allows fixing part of the configuration in order to find a solution with smaller contraction complexity.