Skip to content

[WIP] fix config feature add #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2022
Merged

Conversation

Fanerst
Copy link
Contributor

@Fanerst Fanerst commented Apr 24, 2022

Add the feature that allows fixing part of the configuration in order to find a solution with smaller contraction complexity.

Copy link
Collaborator

@GiggleLiu GiggleLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request! It is really a useful feature to have.

I added a few comments, there are also some general aspects that this PR can be improved. The first one is adding a test, like try fixing some configurations and enumerate the solution space, then see if it works as expected. This is a good place to have the test: https://github.com/QuEraComputing/GenericTensorNetworks.jl/blob/master/test/networks/MaxCut.jl .

It would be nice if you can add a similar feature to other graph problems, which is not hard, I can help with that.

The priority of the changes is

correctness > performance > the rest (e.g. naming)

One you have a test and the CI passes, I can approve this PR.
Thanks again for your effort!

@codecov-commenter
Copy link

Codecov Report

Merging #40 (506f460) into master (2ebb1bf) will increase coverage by 0.09%.
The diff coverage is 96.49%.

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
+ Coverage   93.64%   93.73%   +0.09%     
==========================================
  Files          24       24              
  Lines        1432     1453      +21     
==========================================
+ Hits         1341     1362      +21     
  Misses         91       91              
Impacted Files Coverage Δ
src/GenericTensorNetworks.jl 66.66% <ø> (ø)
src/networks/PaintShop.jl 77.77% <66.66%> (+0.63%) ⬆️
src/networks/Coloring.jl 96.00% <100.00%> (+0.16%) ⬆️
src/networks/DominatingSet.jl 95.45% <100.00%> (+0.21%) ⬆️
src/networks/IndependentSet.jl 96.77% <100.00%> (+0.10%) ⬆️
src/networks/Matching.jl 90.69% <100.00%> (+0.22%) ⬆️
src/networks/MaxCut.jl 95.45% <100.00%> (+0.45%) ⬆️
src/networks/MaximalIS.jl 95.45% <100.00%> (+0.21%) ⬆️
src/networks/Satisfiability.jl 97.95% <100.00%> (+0.04%) ⬆️
src/networks/SetCovering.jl 97.05% <100.00%> (+0.08%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ebb1bf...506f460. Read the comment docs.

@GiggleLiu GiggleLiu merged commit b3cf8dc into QuEraComputing:master Apr 25, 2022
@GiggleLiu
Copy link
Collaborator

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants