Skip to content

Changes based on new version of ProblemReductions #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Dec 13, 2024

Conversation

c-allergic
Copy link
Contributor

@c-allergic c-allergic commented Dec 8, 2024

This pull request aims to utilize the interfaces inProblemReductions to simplify the package.

Updates

  1. The solution size of Coloring/Satisfiability is now defined as the number of violations of colors/clauses. The smaller the better now.
  2. Rename best_solutions to largest_solutions, best2_solutions to largest2_solutions and bestk_solutions to largestk_solutions.
  3. Remove the weights from PaintShop.
  4. Remove the weights on vertices from MaxCut.
  5. SpinGlass is no longer specified by cliques. It is now specified by graphs or hypergraphs. Weights can be defined on both edges and vertices.
  6. Remove unit_disk_graph, replace it with UnitDiskGraph from ProblemReductions.
  7. variables always return 1 to n, where n is the number of variables. Use symbols to access variable names in an SAT.

@c-allergic
Copy link
Contributor Author

c-allergic commented Dec 9, 2024

TODO:

  1. Deprecate the GraphProblem, chweight and ZeroWeight.
  2. Fix test dependency

Copy link
Collaborator

@GiggleLiu GiggleLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@GiggleLiu GiggleLiu merged commit c0576c8 into QuEraComputing:master Dec 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants