CQT-141-Qubit-declaration-added-to-simplest-circuit #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rturrado
reviewed
Oct 3, 2024
Update simplest circuit string representation according to feedback Co-authored-by: Roberto Turrado Camblor <rturrado@gmail.com>
rturrado
requested changes
Oct 16, 2024
|
Remember to run the linters before committing as indicated in the CONTRIBUTING guide, Guy. |
Co-authored-by: Roberto Turrado Camblor <rturrado@gmail.com>
…into CQT-141-Qubit-declaration-added-to-simplest-circuit
rturrado
reviewed
Oct 23, 2024
There was a problem hiding this comment.
Thanks for the changes Guy.
Just a question and a comment:
- Question: have we agreed on adding the
ruff formatto tox.ini? - Comment: can you try to write the circuit strings and the expected outputs in a single line? Just to make the test simpler. You could even put a circuit string and an expected output in the same line.
Thanks!
rturrado
reviewed
Oct 23, 2024
rturrado
previously approved these changes
Oct 23, 2024
rturrado
approved these changes
Oct 24, 2024
rturrado
deleted the
CQT-141-Qubit-declaration-added-to-simplest-circuit
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapts the Writer class such that empty circuit declarations (which are the default for a qubit register in the backend) are not printed to console to avoid confusion.